From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: [PATCH v10 04/11] target/arm: Do not expose all -cpu max features to qtests
Date: Wed, 12 Apr 2023 09:18:22 -0300 [thread overview]
Message-ID: <20230412121829.14452-5-farosas@suse.de> (raw)
In-Reply-To: <20230412121829.14452-1-farosas@suse.de>
We're about to move the TCG-only -cpu max configuration code under
CONFIG_TCG. To be able to do that we need to make sure the qtests
still have some cpu configured even when no other accelerator is
available.
Delineate now what is used with TCG-only and what is also used with
qtests to make the subsequent patches cleaner.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
target/arm/cpu64.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 4537aec141..b3a93e7aa1 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -25,6 +25,8 @@
#include "qemu/module.h"
#include "sysemu/kvm.h"
#include "sysemu/hvf.h"
+#include "sysemu/qtest.h"
+#include "sysemu/tcg.h"
#include "kvm_arm.h"
#include "hvf_arm.h"
#include "qapi/visitor.h"
@@ -1365,10 +1367,14 @@ static void aarch64_max_initfn(Object *obj)
return;
}
+ if (tcg_enabled() || qtest_enabled()) {
+ aarch64_a57_initfn(obj);
+ }
+
/* '-cpu max' for TCG: we currently do this as "A57 with extra things" */
-
- aarch64_a57_initfn(obj);
- aarch64_max_tcg_initfn(obj);
+ if (tcg_enabled()) {
+ aarch64_max_tcg_initfn(obj);
+ }
}
static const ARMCPUInfo aarch64_cpus[] = {
--
2.35.3
next prev parent reply other threads:[~2023-04-12 12:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 12:18 [PATCH v10 00/11] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 01/11] target/arm: Move cortex sysregs into a separate file Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 02/11] target/arm: Remove dead code from cpu_max_set_sve_max_vq Fabiano Rosas
2023-04-21 17:53 ` Philippe Mathieu-Daudé
2023-04-23 10:48 ` Richard Henderson
2023-04-12 12:18 ` [PATCH v10 03/11] target/arm: Extract TCG -cpu max code into a function Fabiano Rosas
2023-04-21 17:56 ` Philippe Mathieu-Daudé
2023-04-23 10:49 ` Richard Henderson
2023-04-12 12:18 ` Fabiano Rosas [this message]
2023-04-21 17:57 ` [PATCH v10 04/11] target/arm: Do not expose all -cpu max features to qtests Philippe Mathieu-Daudé
2023-04-23 10:50 ` Richard Henderson
2023-04-12 12:18 ` [PATCH v10 05/11] target/arm: Move 64-bit TCG CPUs into tcg/ Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 06/11] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-04-21 18:06 ` Philippe Mathieu-Daudé
2023-04-24 12:38 ` Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 07/11] tests/qtest: Fix tests when no KVM or TCG are present Fabiano Rosas
2023-04-20 13:59 ` Igor Mammedov
2023-04-21 15:00 ` Thomas Huth
2023-04-12 12:18 ` [PATCH v10 08/11] tests/avocado: Pass parameters to migration test Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 09/11] arm/Kconfig: Always select SEMIHOSTING when TCG is present Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 10/11] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-04-12 12:18 ` [PATCH v10 11/11] gitlab-ci: Check building KVM-only aarch64 target Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412121829.14452-5-farosas@suse.de \
--to=farosas@suse.de \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).