From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22E2DC7619A for ; Wed, 12 Apr 2023 12:18:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmZQp-0001Qo-JT; Wed, 12 Apr 2023 08:18:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmZQm-0001MS-1j for qemu-devel@nongnu.org; Wed, 12 Apr 2023 08:18:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmZQk-00017W-1h for qemu-devel@nongnu.org; Wed, 12 Apr 2023 08:18:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681301909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zunG/LX2hxnq0bA4UWh70F6Jli6+X91MuYCNH60MUSQ=; b=Vu79K2UOvvWyrJsZ7yZTeRIVBsKBYXFdXl1OUbvmsbH9W1AvCQlAJiND4nP6qsGGJq5zpe 3p7icDHwmP170A9jvo9So22Lx3BuHzK8Qx5ovcnZXFWm+T53xfBcL8qjVRtWQpOZxofKtL VvR51WYzimOiOQzNjrRZQpeE0idkA1Q= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-0EPf5ZJ4M0S3WfG6Fzj5jw-1; Wed, 12 Apr 2023 08:18:28 -0400 X-MC-Unique: 0EPf5ZJ4M0S3WfG6Fzj5jw-1 Received: by mail-ed1-f70.google.com with SMTP id e20-20020a50d4d4000000b00505059e6162so774229edj.11 for ; Wed, 12 Apr 2023 05:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681301904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zunG/LX2hxnq0bA4UWh70F6Jli6+X91MuYCNH60MUSQ=; b=Q0dWRkIkzglph9VAjo1dyvqCIVb3FxfBzrzqBoYhFWQKq8IJVRxKaWJf2S4Qy+hUcY T79JxHdvS20zcdEzf7WC1sxpKVjXiWtQpp4WKMKu+2PJD2+7lNentXRouRanwnu87IkL Uo6dqC4TKlDKZjMJJQfIIe8shymI+k+w30E/QxpKPMSiUmReGmdq7ktGo4YRtb5mSkfD ENJ5MHfhIkgs5PU/rE0IaEj9uy5MtfTyVrnDvh06urfYEhUaAzzeIhH95KPVTzMGGJ6q CTHJBAH3283nKbcFcViYsvmQsbxQ4nDCYIAG8bELmEljxli3j/nB39Mo4zpk70LK9wEQ o+eA== X-Gm-Message-State: AAQBX9eS1UBqYXzujwD4cwoQ7EpXT9pCUhrsx2R1ap/oMhPsCOemGF7Y KCmnl4B/WQbn5hbx5OVZmDf9SKN7V/kx+8zmO2NeJohzfCPj1I9/LegglpgEdX/WP5dugEVRcKy s/yS5GnR3pfOezqQ= X-Received: by 2002:a17:906:8a48:b0:94e:a00:e359 with SMTP id gx8-20020a1709068a4800b0094e0a00e359mr7354446ejc.61.1681301904012; Wed, 12 Apr 2023 05:18:24 -0700 (PDT) X-Google-Smtp-Source: AKy350awL5r1XgP+5RC/q2Qf376DACWk8Z5YbrwykTwrFf85ska78iDuvsvXqDr19jdoJ+7s/3KDqQ== X-Received: by 2002:a17:906:8a48:b0:94e:a00:e359 with SMTP id gx8-20020a1709068a4800b0094e0a00e359mr7354418ejc.61.1681301903662; Wed, 12 Apr 2023 05:18:23 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id xg1-20020a170907320100b0094e5154aeaesm802656ejb.78.2023.04.12.05.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 05:18:22 -0700 (PDT) Date: Wed, 12 Apr 2023 14:18:22 +0200 From: Igor Mammedov To: Fiona Ebner Cc: qemu-devel@nongnu.org, Peter Maydell , Gerd Hoffmann , Ani Sinha , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Thomas Lamprecht Subject: Re: [PULL 19/54] acpi: pc: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors Message-ID: <20230412141822.03507c56@imammedo.users.ipa.redhat.com> In-Reply-To: <0e3f3a98-835f-b26c-649e-a8a35edce660@proxmox.com> References: <20220610075631.367501-1-mst@redhat.com> <20220610075631.367501-20-mst@redhat.com> <20230330102227.39b44b71@imammedo.users.ipa.redhat.com> <0e3f3a98-835f-b26c-649e-a8a35edce660@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 30 Mar 2023 13:58:22 +0200 Fiona Ebner wrote: > Am 30.03.23 um 10:22 schrieb Igor Mammedov: > > On Tue, 28 Mar 2023 14:58:21 +0200 > > Fiona Ebner wrote: > > > >> Am 10.06.22 um 09:57 schrieb Michael S. Tsirkin: > >>> From: Igor Mammedov > >>> > >>> replaces ad-hoc build_isa_devices_aml() with generic AcpiDevAmlIf > >>> way to build bridge AML including all devices that are attached to > >>> its ISA bus. > >>> > >>> Later when PCI is converted to AcpiDevAmlIf, build_piix4_isa_bridge() > >>> will also be dropped since PCI parts itself will take care of > >>> building device prologue/epilogue AML for each enumerated PCI > >>> device. > >>> > >>> Expected AML change is contextual, where ISA devices are moved > >>> from separately declared _SB.PCI0.ISA scope , directly under > >>> Device(ISA) node. > >>> > >>> Signed-off-by: Igor Mammedov > >>> Acked-by: Gerd Hoffmann > >>> Message-Id: <20220608135340.3304695-20-imammedo@redhat.com> > >>> Reviewed-by: Michael S. Tsirkin > >>> Signed-off-by: Michael S. Tsirkin > >> > >> Hi, > >> while trying to reproduce another issue, I ended up with a Windows 10 > >> guest that would boot with QEMU 7.0, but get stuck after the Windows > >> logo/spinning circles with QEMU 7.1 (also with 8.0.0-rc1). Machine type > >> is pc-i440fx-6.2[0]. Bisecting led to this commit. > >> > >> It only happens the first time the VM is booted, killing the process and > >> re-trying always worked afterwards. So it's not a big deal and might > >> just be some ACPI-related Windows quirk. But I thought I should ask here > >> to be sure. > >> > >> For bisecting, I restored the disk state after each attempt. While > >> getting stuck sometimes took 3-4 attempts, I tested about 10 times until > >> I declared a commit good, and re-tested the commit before this one 15 > >> times, so I'm pretty sure this is the one where the issue started appearing. > >> > >> So, anything that could potentially be wrong with the commit or is this > >> most likely just some Windows quirk/bug we can't do much about? > >> > >> If you need more information, please let me know! > > > > Please describe in more detail your setup/steps where it reproduces > > (incl. Windows version/build, used QEMU CLI) so I could try to reproduce it locally. > > > > (in past there were issues with German version that some where > > experience but not reproducible on my side, that resolved with > > upgrading to newer QEMU (if I recall correctly issue was opened > > on QEMU's gitlab tracker)) > > > > Windows 10 Education > Version 1809 > Build 17763.1 > > It's not the German ISO, I used default settings (except location > Austria and German keymap) and I don't think I did anything other than > shutdown after the install was over. > > The command line is below. I did use our patched QEMU builds when I got > into the situation, but I don't think they touch anything ACPI-related > and bisecting was done without our patches on top. > > I tried to reproduce the situation again from scratch today, but wasn't > able to. I do still have the problematic disk (snapshot) where the issue > occurs as an LVM-Thin volume. If you'd like to have access to that, > please send me a direct mail and we can discuss the details there. I couldn't reproduce the issue on my host either. If you still have access to 'broken' disk image, you can try to enable kernel debug mode in guest and try to attach with debugger to it to see where it is stuck. quick instructions how to do it: https://gitlab.com/qemu-project/qemu/-/issues/774#note_1270248862 or read more extensive MS docs on topic. > > Best Regards, > Fiona > > >> > >> Best Regards, > >> Fiona > >> > >> [0] command line: > >>> ./qemu-system-x86_64 \ > >>> -accel 'kvm' \ > >>> -name 'stuckafterrollbackonboot,debug-threads=on' \ > >>> -no-shutdown \ > >>> -chardev 'socket,id=qmp,path=/var/run/qemu-server/161.qmp,server=on,wait=off' \ > >>> -mon 'chardev=qmp,mode=control' \ > >>> -chardev 'socket,id=qmp-event,path=/var/run/qmeventd.sock,reconnect=5' \ > >>> -mon 'chardev=qmp-event,mode=control' \ > >>> -pidfile /var/run/qemu-server/161.pid \ > >>> -smbios 'type=1,uuid=f2b77ed0-73c1-4372-9490-b2c1b59431af' \ > >>> -smp '4,sockets=1,cores=4,maxcpus=4' \ > >>> -nodefaults \ > >>> -boot 'menu=on,strict=on,reboot-timeout=1000,splash=/usr/share/qemu-server/bootsplash.jpg' \ > >>> -vnc 'unix:/var/run/qemu-server/161.vnc,password=on' \ > >>> -no-hpet \ > >>> -cpu 'kvm64,enforce,hv_ipi,hv_relaxed,hv_reset,hv_runtime,hv_spinlocks=0x1fff,hv_stimer,hv_synic,hv_time,hv_vapic,hv_vpindex,+kvm_pv_eoi,+kvm_pv_unhalt,+lahf_lm,+sep' \ > >>> -m 6144 \ > >>> -device 'pci-bridge,id=pci.1,chassis_nr=1,bus=pci.0,addr=0x1e' \ > >>> -device 'pci-bridge,id=pci.2,chassis_nr=2,bus=pci.0,addr=0x1f' \ > >>> -device 'pci-bridge,id=pci.3,chassis_nr=3,bus=pci.0,addr=0x5' \ > >>> -device 'vmgenid,guid=faa21a64-5921-45fe-9ff3-1f132b9ed029' \ > >>> -device 'piix3-usb-uhci,id=uhci,bus=pci.0,addr=0x1.0x2' \ > >>> -device 'usb-tablet,id=tablet,bus=uhci.0,port=1' \ > >>> -device 'VGA,id=vga,bus=pci.0,addr=0x2,edid=off' \ > >>> -device 'virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3,free-page-reporting=on' \ > >>> -iscsi 'initiator-name=iqn.1993-08.org.debian:01:7d9a912f961' \ > >>> -device 'ahci,id=ahci0,multifunction=on,bus=pci.0,addr=0x7' \ > >>> -drive 'file=/dev/pve/vm-161-disk-0,if=none,id=drive-sata0,format=raw,cache=none,aio=io_uring,detect-zeroes=on' \ > >>> -device 'ide-hd,bus=ahci0.0,drive=drive-sata0,id=sata0,bootindex=100' \ > >>> -netdev 'type=tap,id=net0,ifname=tap161i0,script=/var/lib/qemu-server/pve-bridge,downscript=/var/lib/qemu-server/pve-bridgedown' \ > >>> -device 'e1000,mac=42:BF:8B:AE:68:05,netdev=net0,bus=pci.0,addr=0x12,id=net0,bootindex=102' \ > >>> -rtc 'driftfix=slew,base=localtime' \ > >>> -machine 'type=pc-i440fx-6.2' \ > >>> -global 'kvm-pit.lost_tick_policy=discard' > >> > >