* [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest
@ 2023-04-13 21:43 John Snow
2023-04-13 21:45 ` John Snow
2023-04-14 8:58 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: John Snow @ 2023-04-13 21:43 UTC (permalink / raw)
To: qemu-devel
Cc: Beraldo Leal, Wainer dos Santos Moschetta, Cleber Rosa,
Paolo Bonzini, Peter Maydell, kvm, Philippe Mathieu-Daudé,
Alex Bennée, John Snow
The tests will fail mysteriously with EOFError otherwise, because the VM
fails to boot and quickly disconnects from the QMP socket. Skip these
tests when we didn't compile with slirp.
Fixes: c8cb603293fd (tests/avocado: Test Xen guest support under KVM)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/avocado/kvm_xen_guest.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py
index 5391283113..171274bc4c 100644
--- a/tests/avocado/kvm_xen_guest.py
+++ b/tests/avocado/kvm_xen_guest.py
@@ -45,6 +45,7 @@ def get_asset(self, name, sha1):
def common_vm_setup(self):
# We also catch lack of KVM_XEN support if we fail to launch
self.require_accelerator("kvm")
+ self.require_netdev('user')
self.vm.set_console()
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest
2023-04-13 21:43 [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest John Snow
@ 2023-04-13 21:45 ` John Snow
2023-04-14 8:58 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2023-04-13 21:45 UTC (permalink / raw)
To: qemu-devel
Cc: Beraldo Leal, Wainer dos Santos Moschetta, Cleber Rosa,
Paolo Bonzini, Peter Maydell, kvm, Philippe Mathieu-Daudé,
Alex Bennée
On Thu, Apr 13, 2023 at 5:43 PM John Snow <jsnow@redhat.com> wrote:
>
> The tests will fail mysteriously with EOFError otherwise, because the VM
> fails to boot and quickly disconnects from the QMP socket. Skip these
> tests when we didn't compile with slirp.
>
Full disclosure: I only tested this patch in conjunction with a much
larger series that also messed around with tests, but it seemed to
work OK on my local machine in that circumstance. Didn't find any
other tests that needed this same treatment.
--js
> Fixes: c8cb603293fd (tests/avocado: Test Xen guest support under KVM)
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/avocado/kvm_xen_guest.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py
> index 5391283113..171274bc4c 100644
> --- a/tests/avocado/kvm_xen_guest.py
> +++ b/tests/avocado/kvm_xen_guest.py
> @@ -45,6 +45,7 @@ def get_asset(self, name, sha1):
> def common_vm_setup(self):
> # We also catch lack of KVM_XEN support if we fail to launch
> self.require_accelerator("kvm")
> + self.require_netdev('user')
>
> self.vm.set_console()
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest
2023-04-13 21:43 [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest John Snow
2023-04-13 21:45 ` John Snow
@ 2023-04-14 8:58 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-04-14 8:58 UTC (permalink / raw)
To: John Snow
Cc: qemu-devel, Beraldo Leal, Wainer dos Santos Moschetta,
Cleber Rosa, Paolo Bonzini, kvm, Philippe Mathieu-Daudé,
Alex Bennée
On Thu, 13 Apr 2023 at 22:43, John Snow <jsnow@redhat.com> wrote:
>
> The tests will fail mysteriously with EOFError otherwise, because the VM
> fails to boot and quickly disconnects from the QMP socket. Skip these
> tests when we didn't compile with slirp.
>
> Fixes: c8cb603293fd (tests/avocado: Test Xen guest support under KVM)
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/avocado/kvm_xen_guest.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py
> index 5391283113..171274bc4c 100644
> --- a/tests/avocado/kvm_xen_guest.py
> +++ b/tests/avocado/kvm_xen_guest.py
> @@ -45,6 +45,7 @@ def get_asset(self, name, sha1):
> def common_vm_setup(self):
> # We also catch lack of KVM_XEN support if we fail to launch
> self.require_accelerator("kvm")
> + self.require_netdev('user')
>
> self.vm.set_console()
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 8:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 21:43 [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest John Snow
2023-04-13 21:45 ` John Snow
2023-04-14 8:58 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).