qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,
	libvir-list@redhat.com, Markus Armbruster <armbru@redhat.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Eric Blake <eblake@redhat.com>
Subject: [PATCH v3 06/10] Document that -singlestep command line option is deprecated
Date: Mon, 17 Apr 2023 17:40:37 +0100	[thread overview]
Message-ID: <20230417164041.684562-7-peter.maydell@linaro.org> (raw)
In-Reply-To: <20230417164041.684562-1-peter.maydell@linaro.org>

Document that the -singlestep command line option is now
deprecated, as it is replaced by either the TCG accelerator
property 'one-insn-per-tb' for system emulation or the new
'-one-insn-per-tb' option for usermode emulation, and remove
the only use of the deprecated syntax from a README.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 docs/about/deprecated.rst | 16 ++++++++++++++++
 qemu-options.hx           |  5 +++--
 tcg/tci/README            |  2 +-
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 1ca9dc33d61..3c62671dac1 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -111,6 +111,22 @@ Use ``-machine acpi=off`` instead.
 The HAXM project has been retired (see https://github.com/intel/haxm#status).
 Use "whpx" (on Windows) or "hvf" (on macOS) instead.
 
+``-singlestep`` (since 8.1)
+'''''''''''''''''''''''''''
+
+The ``-singlestep`` option has been turned into an accelerator property,
+and given a name that better reflects what it actually does.
+Use ``-accel tcg,one-insn-per-tb=on`` instead.
+
+User-mode emulator command line arguments
+-----------------------------------------
+
+``-singlestep`` (since 8.1)
+'''''''''''''''''''''''''''
+
+The ``-singlestep`` option has been given a name that better reflects
+what it actually does. For both linux-user and bsd-user, use the
+new ``-one-insn-per-tb`` option instead.
 
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
diff --git a/qemu-options.hx b/qemu-options.hx
index 1dffd36884e..6a59e997497 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4159,10 +4159,11 @@ SRST
 ERST
 
 DEF("singlestep", 0, QEMU_OPTION_singlestep, \
-    "-singlestep     always run in singlestep mode\n", QEMU_ARCH_ALL)
+    "-singlestep     deprecated synonym for -accel tcg,one-insn-per-tb=on\n", QEMU_ARCH_ALL)
 SRST
 ``-singlestep``
-    Run the emulation in single step mode.
+    This is a deprecated synonym for the TCG accelerator property
+    ``one-insn-per-tb``.
 ERST
 
 DEF("preconfig", 0, QEMU_OPTION_preconfig, \
diff --git a/tcg/tci/README b/tcg/tci/README
index f72a40a395a..4a8b5b54018 100644
--- a/tcg/tci/README
+++ b/tcg/tci/README
@@ -49,7 +49,7 @@ The only difference from running QEMU with TCI to running without TCI
 should be speed. Especially during development of TCI, it was very
 useful to compare runs with and without TCI. Create /tmp/qemu.log by
 
-        qemu-system-i386 -d in_asm,op_opt,cpu -D /tmp/qemu.log -singlestep
+        qemu-system-i386 -d in_asm,op_opt,cpu -D /tmp/qemu.log -accel tcg,one-insn-per-tb=on
 
 once with interpreter and once without interpreter and compare the resulting
 qemu.log files. This is also useful to see the effects of additional
-- 
2.34.1



  parent reply	other threads:[~2023-04-17 16:41 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 16:40 [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-04-17 16:40 ` [PATCH v3 01/10] make one-insn-per-tb an accel option Peter Maydell
2023-04-17 16:40 ` [PATCH v3 02/10] softmmu: Don't use 'singlestep' global in QMP and HMP commands Peter Maydell
2023-04-20  8:54   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global Peter Maydell
2023-04-18  8:02   ` Richard Henderson
2023-04-18  8:05   ` Richard Henderson
2023-04-18  9:44     ` Peter Maydell
2023-04-20  8:55   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' Peter Maydell
2023-04-20  9:13   ` Philippe Mathieu-Daudé
2023-04-20  9:19     ` Peter Maydell
2023-04-20 10:05       ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 05/10] bsd-user: " Peter Maydell
2023-04-20  9:13   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` Peter Maydell [this message]
2023-04-20  8:56   ` [PATCH v3 06/10] Document that -singlestep command line option is deprecated Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status' Peter Maydell
2023-04-18  8:06   ` Richard Henderson
2023-04-20  9:02   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 08/10] hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep' Peter Maydell
2023-04-20  9:03   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 09/10] qapi/run-state.json: Fix missing newline at end of file Peter Maydell
2023-04-20  9:04   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo Peter Maydell
2023-04-18  8:08   ` Richard Henderson
2023-04-20  9:05   ` Philippe Mathieu-Daudé
2023-04-24 10:06   ` Peter Maydell
     [not found]   ` <87jzy18oqv.fsf@pond.sub.org>
2023-04-25 12:13     ` Peter Maydell
2023-04-25 13:08       ` Markus Armbruster
2023-05-02 10:22 ` [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-05-02 10:43   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417164041.684562-7-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).