From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
peterx@redhat.com
Subject: [PATCH 0/3] migration/hostmem: Allow to fail early for postcopy on specific fs type
Date: Tue, 18 Apr 2023 18:57:46 -0400 [thread overview]
Message-ID: <20230418225749.1049185-1-peterx@redhat.com> (raw)
Postcopy can fail in a weird way when guest mem is put onto a random file:
https://bugzilla.redhat.com/show_bug.cgi?id=2057267
It's because we only check userfault privilege on dest QEMU but don't check
memory types. We do so only until the UFFDIO_REGISTER right after we
switch to postcopy live migration from precopy but it could be too late.
This series tries to make it fail early by checking ramblock fs type if
backed by a memory-backend-file.
Now when it happens it'll fail the dest QEMU from the start:
./qemu-system-x86_64 \
-global migration.x-postcopy-ram=on \
-incoming defer \
-object memory-backend-file,id=mem,size=128M,mem-path=$memfile \
-machine memory-backend=mem
qemu-system-x86_64: Host backend files need to be TMPFS or HUGETLBFS only
qemu-system-x86_64: Postcopy is not supported
It will also fail e.g. QMP migrate-set-capabilities properly.
Please have a look, thanks.
Peter Xu (3):
hostmem: Detect and cache fs type for file hostmem
vl.c: Create late backends before migration object
migration/postcopy: Detect file system on dest host
backends/hostmem-file.c | 37 ++++++++++++++++++++++++++++++++++++-
include/sysemu/hostmem.h | 1 +
migration/postcopy-ram.c | 28 ++++++++++++++++++++++++----
softmmu/vl.c | 9 +++++++--
4 files changed, 68 insertions(+), 7 deletions(-)
--
2.39.1
next reply other threads:[~2023-04-18 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 22:57 Peter Xu [this message]
2023-04-18 22:57 ` [PATCH 1/3] hostmem: Detect and cache fs type for file hostmem Peter Xu
2023-04-19 7:01 ` Daniel P. Berrangé
2023-04-19 7:28 ` David Hildenbrand
2023-04-19 14:46 ` Peter Xu
2023-04-18 22:57 ` [PATCH 2/3] vl.c: Create late backends before migration object Peter Xu
2023-04-18 22:57 ` [PATCH 3/3] migration/postcopy: Detect file system on dest host Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418225749.1049185-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).