From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
peterx@redhat.com
Subject: [PATCH 2/3] vl.c: Create late backends before migration object
Date: Tue, 18 Apr 2023 18:57:48 -0400 [thread overview]
Message-ID: <20230418225749.1049185-3-peterx@redhat.com> (raw)
In-Reply-To: <20230418225749.1049185-1-peterx@redhat.com>
The migration object may want to check against different types of memory
when initialized. Delay the creation to be after late backends.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
softmmu/vl.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index ea20b23e4c..ad394b402f 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -3583,14 +3583,19 @@ void qemu_init(int argc, char **argv)
machine_class->name, machine_class->deprecation_reason);
}
+ /*
+ * Create backends before creating migration objects, so that it can
+ * check against compatibilities on the backend memories (e.g. postcopy
+ * over memory-backend-file objects).
+ */
+ qemu_create_late_backends();
+
/*
* Note: creates a QOM object, must run only after global and
* compat properties have been set up.
*/
migration_object_init();
- qemu_create_late_backends();
-
/* parse features once if machine provides default cpu_type */
current_machine->cpu_type = machine_class->default_cpu_type;
if (cpu_option) {
--
2.39.1
next prev parent reply other threads:[~2023-04-18 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 22:57 [PATCH 0/3] migration/hostmem: Allow to fail early for postcopy on specific fs type Peter Xu
2023-04-18 22:57 ` [PATCH 1/3] hostmem: Detect and cache fs type for file hostmem Peter Xu
2023-04-19 7:01 ` Daniel P. Berrangé
2023-04-19 7:28 ` David Hildenbrand
2023-04-19 14:46 ` Peter Xu
2023-04-18 22:57 ` Peter Xu [this message]
2023-04-18 22:57 ` [PATCH 3/3] migration/postcopy: Detect file system on dest host Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418225749.1049185-3-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).