* [PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI
@ 2023-04-19 11:13 Thomas Huth
2023-04-20 13:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2023-04-19 11:13 UTC (permalink / raw)
To: qemu-devel, Marcel Apfelbaum, Yuval Shaia; +Cc: qemu-trivial
The "pvrdma" device is only usable in conjunction with the "vmxnet3"
NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().
By adding this dependency, the amount of total files that have to
be compiled for a configuration with all targets decreases by 64
files (!), since the rdma code is marked as target specific and thus
got recompiled for all targets that enable PCI so far.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/rdma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/Kconfig b/hw/rdma/Kconfig
index 8e2211288f..840320bdc0 100644
--- a/hw/rdma/Kconfig
+++ b/hw/rdma/Kconfig
@@ -1,3 +1,3 @@
config VMW_PVRDMA
default y if PCI_DEVICES
- depends on PVRDMA && PCI && MSI_NONBROKEN
+ depends on PVRDMA && MSI_NONBROKEN && VMXNET3_PCI
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI
2023-04-19 11:13 [PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI Thomas Huth
@ 2023-04-20 13:55 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-20 13:55 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Marcel Apfelbaum, Yuval Shaia; +Cc: qemu-trivial
On 19/4/23 13:13, Thomas Huth wrote:
> The "pvrdma" device is only usable in conjunction with the "vmxnet3"
> NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().
>
> By adding this dependency, the amount of total files that have to
> be compiled for a configuration with all targets decreases by 64
> files (!), since the rdma code is marked as target specific and thus
> got recompiled for all targets that enable PCI so far.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/rdma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-20 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 11:13 [PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI Thomas Huth
2023-04-20 13:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).