* [PATCH] cpu: Remove parameter of list_cpus()
@ 2023-04-19 12:48 Thomas Huth
2023-04-19 13:40 ` Alex Bennée
2023-04-20 8:42 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2023-04-19 12:48 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini, Eduardo Habkost, Marcel Apfelbaum
Cc: qemu-trivial, Philippe Mathieu-Daudé, Yanan Wang
The "optarg" parameter is completely unused, so let's drop it.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/exec/cpu-common.h | 2 +-
cpu.c | 2 +-
softmmu/vl.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index 6feaa40ca7..565c2030c1 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -165,6 +165,6 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr,
/* vl.c */
extern int singlestep;
-void list_cpus(const char *optarg);
+void list_cpus(void);
#endif /* CPU_COMMON_H */
diff --git a/cpu.c b/cpu.c
index 849bac062c..9105c85404 100644
--- a/cpu.c
+++ b/cpu.c
@@ -284,7 +284,7 @@ const char *parse_cpu_option(const char *cpu_option)
return cpu_type;
}
-void list_cpus(const char *optarg)
+void list_cpus(void)
{
/* XXX: implement xxx_cpu_list for targets that still miss it */
#if defined(cpu_list)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index ea20b23e4c..5cb72a56fc 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2432,7 +2432,7 @@ static void qemu_process_help_options(void)
* to say '-cpu help -machine something'.
*/
if (cpu_option && is_help_option(cpu_option)) {
- list_cpus(cpu_option);
+ list_cpus();
exit(0);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpu: Remove parameter of list_cpus()
2023-04-19 12:48 [PATCH] cpu: Remove parameter of list_cpus() Thomas Huth
@ 2023-04-19 13:40 ` Alex Bennée
2023-04-20 8:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2023-04-19 13:40 UTC (permalink / raw)
To: Thomas Huth
Cc: Paolo Bonzini, Eduardo Habkost, Marcel Apfelbaum, qemu-trivial,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> The "optarg" parameter is completely unused, so let's drop it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpu: Remove parameter of list_cpus()
2023-04-19 12:48 [PATCH] cpu: Remove parameter of list_cpus() Thomas Huth
2023-04-19 13:40 ` Alex Bennée
@ 2023-04-20 8:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-20 8:42 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini, Eduardo Habkost,
Marcel Apfelbaum
Cc: qemu-trivial, Yanan Wang
On 19/4/23 14:48, Thomas Huth wrote:
> The "optarg" parameter is completely unused, so let's drop it.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> include/exec/cpu-common.h | 2 +-
> cpu.c | 2 +-
> softmmu/vl.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-20 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 12:48 [PATCH] cpu: Remove parameter of list_cpus() Thomas Huth
2023-04-19 13:40 ` Alex Bennée
2023-04-20 8:42 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).