From: Lukas Straub <lukasstraub2@web.de>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v2 14/13] migration: Initialize and cleanup decompression in migration.c
Date: Thu, 20 Apr 2023 11:59:50 +0200 [thread overview]
Message-ID: <20230420095950.057fe69b@gecko.fritz.box> (raw)
In-Reply-To: <cover.1681983401.git.lukasstraub2@web.de>
[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]
This fixes compress with colo.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
Oops, this one slipped trough
migration/migration.c | 9 +++++++++
migration/ram.c | 5 -----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index bda4789193..e7d082a208 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -26,6 +26,7 @@
#include "sysemu/cpu-throttle.h"
#include "rdma.h"
#include "ram.h"
+#include "ram-compress.h"
#include "migration/global_state.h"
#include "migration/misc.h"
#include "migration.h"
@@ -316,6 +317,7 @@ void migration_incoming_state_destroy(void)
struct MigrationIncomingState *mis = migration_incoming_get_current();
multifd_load_cleanup();
+ compress_threads_load_cleanup();
if (mis->to_src_file) {
/* Tell source that we are done */
@@ -598,6 +600,12 @@ process_incoming_migration_co(void *opaque)
Error *local_err = NULL;
assert(mis->from_src_file);
+
+ if (compress_threads_load_setup(mis->from_src_file)) {
+ error_report("Failed to setup decompress threads");
+ goto fail;
+ }
+
mis->migration_incoming_co = qemu_coroutine_self();
mis->largest_page_size = qemu_ram_pagesize_largest();
postcopy_state_set(POSTCOPY_INCOMING_NONE);
@@ -663,6 +671,7 @@ fail:
qemu_fclose(mis->from_src_file);
multifd_load_cleanup();
+ compress_threads_load_cleanup();
exit(EXIT_FAILURE);
}
diff --git a/migration/ram.c b/migration/ram.c
index ccfedf4fb5..344f326065 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3560,10 +3560,6 @@ void colo_release_ram_cache(void)
*/
static int ram_load_setup(QEMUFile *f, void *opaque)
{
- if (compress_threads_load_setup(f)) {
- return -1;
- }
-
xbzrle_load_setup();
ramblock_recv_map_init();
@@ -3579,7 +3575,6 @@ static int ram_load_cleanup(void *opaque)
}
xbzrle_load_cleanup();
- compress_threads_load_cleanup();
RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
g_free(rb->receivedmap);
--
2.40.0
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-20 10:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:47 [PATCH v2 00/13] migration/ram.c: Refactor compress code Lukas Straub
2023-04-20 9:47 ` [PATCH v2 01/13] qtest/migration-test.c: Add postcopy tests with compress enabled Lukas Straub
2023-04-20 10:20 ` Juan Quintela
2023-04-20 10:37 ` Lukas Straub
2023-04-20 21:12 ` Juan Quintela
2023-04-20 9:47 ` [PATCH v2 02/13] ram.c: Let the compress threads return a CompressResult enum Lukas Straub
2023-04-20 21:13 ` Juan Quintela
2023-04-20 9:47 ` [PATCH v2 03/13] ram.c: Dont change param->block in the compress thread Lukas Straub
2023-04-20 21:13 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 04/13] ram.c: Reset result after sending queued data Lukas Straub
2023-04-28 11:59 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 05/13] ram.c: Do not call save_page_header() from compress threads Lukas Straub
2023-04-28 12:02 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 06/13] ram.c: Call update_compress_thread_counts from compress_send_queued_data Lukas Straub
2023-04-28 12:10 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 07/13] ram.c: Remove last ram.c dependency from the core compress code Lukas Straub
2023-04-28 12:14 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 08/13] ram.c: Introduce whitespace (squash with next patch) Lukas Straub
2023-04-28 16:13 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 09/13] ram.c: Move core compression code into its own file Lukas Straub
2023-04-20 9:48 ` [PATCH v2 10/13] ram.c: Remove whitespace (squash with previous patch) Lukas Straub
2023-04-28 16:15 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 11/13] ram.c: Move core decompression code into its own file Lukas Straub
2023-04-28 17:22 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 12/13] ram compress: Assert that the file buffer matches the result Lukas Straub
2023-04-28 17:24 ` Juan Quintela
2023-04-20 9:48 ` [PATCH v2 13/13] ram-compress.c: Make target independent Lukas Straub
2023-04-28 17:29 ` Juan Quintela
2023-04-20 9:59 ` Lukas Straub [this message]
2023-04-28 17:33 ` [PATCH v2 14/13] migration: Initialize and cleanup decompression in migration.c Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420095950.057fe69b@gecko.fritz.box \
--to=lukasstraub2@web.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).