From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael Roth" <michael.roth@amd.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Greg Kurz" <groug@kaod.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 05/10] qapi: make the vcpu parameters deprecated for 8.1
Date: Thu, 20 Apr 2023 16:00:04 +0100 [thread overview]
Message-ID: <20230420150009.1675181-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230420150009.1675181-1-alex.bennee@linaro.org>
I don't think I can remove the parameters directly but certainly mark
them as deprecated.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
qapi/trace.json | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/qapi/trace.json b/qapi/trace.json
index 6c6982a587..74dd66ef4a 100644
--- a/qapi/trace.json
+++ b/qapi/trace.json
@@ -33,9 +33,9 @@
#
# @name: Event name.
# @state: Tracing state.
-# @vcpu: Whether this is a per-vCPU event (since 2.7).
+# @vcpu: Whether this is a per-vCPU event (deprecated since 8.1).
#
-# An event is per-vCPU if it has the "vcpu" property in the "trace-events"
+# There are no longer any events with the "vcpu" property in the "trace-events"
# files.
#
# Since: 2.2
@@ -49,19 +49,15 @@
# Query the state of events.
#
# @name: Event name pattern (case-sensitive glob).
-# @vcpu: The vCPU to query (any by default; since 2.7).
+# @vcpu: The vCPU to query (deprecated since 8.1).
#
# Returns: a list of @TraceEventInfo for the matching events
#
# An event is returned if:
#
# - its name matches the @name pattern, and
-# - if @vcpu is given, the event has the "vcpu" property.
#
-# Therefore, if @vcpu is given, the operation will only match per-vCPU events,
-# returning their state on the specified vCPU. Special case: if @name is an
-# exact match, @vcpu is given and the event does not have the "vcpu" property,
-# an error is returned.
+# There are no longer any per-vCPU events
#
# Since: 2.2
#
@@ -84,16 +80,12 @@
# @name: Event name pattern (case-sensitive glob).
# @enable: Whether to enable tracing.
# @ignore-unavailable: Do not match unavailable events with @name.
-# @vcpu: The vCPU to act upon (all by default; since 2.7).
+# @vcpu: The vCPU to act upon (deprecated since 8.1).
#
# An event's state is modified if:
-# - its name matches the @name pattern, and
-# - if @vcpu is given, the event has the "vcpu" property.
+# - its name matches the @name pattern
#
-# Therefore, if @vcpu is given, the operation will only match per-vCPU events,
-# setting their state on the specified vCPU. Special case: if @name is an exact
-# match, @vcpu is given and the event does not have the "vcpu" property, an
-# error is returned.
+# There are no longer and per-vCPU events so specifying it will never match.
#
# Since: 2.2
#
--
2.39.2
next prev parent reply other threads:[~2023-04-20 15:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:59 [PATCH 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-04-20 15:00 ` [PATCH 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-04-20 15:29 ` Warner Losh
2023-04-20 15:00 ` [PATCH 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-04-21 6:47 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-04-20 15:00 ` Alex Bennée [this message]
2023-04-20 15:00 ` [PATCH 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-04-20 15:00 ` [PATCH 07/10] trace: remove control-vcpu.h Alex Bennée
2023-04-21 6:50 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-04-20 15:00 ` [PATCH 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-04-20 15:35 ` Christian Schoenebeck
2023-04-21 6:51 ` Philippe Mathieu-Daudé
2023-04-20 15:00 ` [PATCH 10/10] xxhash: remove qemu_xxhash7 Alex Bennée
2023-04-21 6:53 ` Philippe Mathieu-Daudé
2023-05-01 20:25 ` [PATCH 00/10] tracing: remove dynamic vcpu state Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420150009.1675181-6-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).