From: Fei Wu <fei2.wu@intel.com>
To: alex.bennee@linaro.org, richard.henderson@linaro.org,
qemu-devel@nongnu.org
Cc: Fei Wu <fei2.wu@intel.com>
Subject: [PATCH v11 00/14] TCG code quality tracking
Date: Fri, 21 Apr 2023 21:24:07 +0800 [thread overview]
Message-ID: <20230421132421.1617479-1-fei2.wu@intel.com> (raw)
This patch series were done by Vanderson and Alex originally in 2019, I
(Fei Wu) rebased them on latest upstream from:
https://github.com/stsquad/qemu/tree/tcg/tbstats-and-perf-v10
and send out this review per Alex's request, I will continue to address
any future review comments here. As it's been a very long time and there
are lots of conflicts during rebase, it's my fault if I introduce any
problems during the process.
Alex in his v10 series has addressed part of v9 comments:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg650258.html
and I tried to figure out some others. It looks to me not all of v9
comments had made complete agreement and I didn't join that discussion
then, so please comment to this series and I will fix them up if
necessary.
Alex Bennée (5):
accel/tcg: move profiler dev_time to tb_stats
accel/tcg: convert profiling of restore operations to TBStats
accel/tcg: convert profiling of code generation to TBStats
tb-stats: reset the tracked TBs on a tb_flush
configure: remove the final bits of --profiler support
Vanderson M. do Rosario (9):
accel/tcg: introduce TBStatistics structure
accel: collecting TB execution count
accel: collecting JIT statistics
accel: replacing part of CONFIG_PROFILER with TBStats
accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER
debug: add -d tb_stats to control TBStatistics collection:
monitor: adding tb_stats hmp command
Adding info [tb-list|tb] commands to HMP (WIP)
tb-stats: dump hot TBs at the end of the execution
accel/tcg/cpu-exec.c | 6 +
accel/tcg/meson.build | 1 +
accel/tcg/monitor.c | 133 +++++--
accel/tcg/tb-context.h | 1 +
accel/tcg/tb-hash.h | 7 +
accel/tcg/tb-maint.c | 20 +
accel/tcg/tb-stats.c | 689 ++++++++++++++++++++++++++++++++++
accel/tcg/tcg-accel-ops.c | 15 +-
accel/tcg/tcg-runtime.c | 8 +
accel/tcg/tcg-runtime.h | 2 +
accel/tcg/translate-all.c | 147 ++++++--
accel/tcg/translator.c | 13 +
disas.c | 31 +-
hmp-commands-info.hx | 16 +
hmp-commands.hx | 16 +
include/exec/exec-all.h | 3 +
include/exec/gen-icount.h | 2 +
include/exec/tb-stats-dump.h | 21 ++
include/exec/tb-stats-flags.h | 32 ++
include/exec/tb-stats.h | 165 ++++++++
include/monitor/hmp.h | 3 +
include/qemu/log-for-trace.h | 6 +-
include/qemu/log.h | 3 +
include/qemu/timer.h | 5 +-
include/tcg/tcg.h | 50 ++-
linux-user/exit.c | 2 +
meson.build | 2 -
meson_options.txt | 2 -
scripts/meson-buildoptions.sh | 3 -
softmmu/runstate.c | 10 +-
stubs/meson.build | 1 +
stubs/tb-stats.c | 32 ++
tcg/tcg.c | 224 +++--------
util/log.c | 103 ++++-
34 files changed, 1482 insertions(+), 292 deletions(-)
create mode 100644 accel/tcg/tb-stats.c
create mode 100644 include/exec/tb-stats-dump.h
create mode 100644 include/exec/tb-stats-flags.h
create mode 100644 include/exec/tb-stats.h
create mode 100644 stubs/tb-stats.c
--
2.25.1
next reply other threads:[~2023-04-21 13:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 13:24 Fei Wu [this message]
2023-04-21 13:24 ` [PATCH v11 01/14] accel/tcg: introduce TBStatistics structure Fei Wu
2023-05-03 8:12 ` Richard Henderson
2023-05-08 9:52 ` Wu, Fei
2023-04-21 13:24 ` [PATCH v11 02/14] accel: collecting TB execution count Fei Wu
2023-05-03 8:28 ` Richard Henderson
2023-05-08 10:02 ` Wu, Fei
2023-04-21 13:24 ` [PATCH v11 03/14] accel: collecting JIT statistics Fei Wu
2023-04-21 13:24 ` [PATCH v11 04/14] accel: replacing part of CONFIG_PROFILER with TBStats Fei Wu
2023-04-21 13:24 ` [PATCH v11 05/14] accel/tcg: move profiler dev_time to tb_stats Fei Wu
2023-04-21 13:24 ` [PATCH v11 06/14] accel/tcg: convert profiling of restore operations to TBStats Fei Wu
2023-04-21 13:24 ` [PATCH v11 07/14] accel/tcg: convert profiling of code generation " Fei Wu
2023-04-21 13:24 ` [PATCH v11 08/14] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER Fei Wu
2023-04-21 13:24 ` [PATCH v11 09/14] debug: add -d tb_stats to control TBStatistics collection: Fei Wu
2023-04-21 13:24 ` [PATCH v11 10/14] monitor: adding tb_stats hmp command Fei Wu
2023-04-21 13:24 ` [PATCH v11 11/14] tb-stats: reset the tracked TBs on a tb_flush Fei Wu
2023-04-21 13:24 ` [PATCH v11 12/14] Adding info [tb-list|tb] commands to HMP (WIP) Fei Wu
2023-04-21 14:43 ` Wu, Fei
2023-04-21 13:24 ` [PATCH v11 13/14] tb-stats: dump hot TBs at the end of the execution Fei Wu
2023-04-21 13:24 ` [PATCH v11 14/14] configure: remove the final bits of --profiler support Fei Wu
2023-04-21 16:42 ` [PATCH v11 00/14] TCG code quality tracking Alex Bennée
2023-05-12 8:07 ` Wu, Fei
2023-05-12 8:42 ` Alex Bennée
2023-05-12 8:58 ` Wu, Fei
2023-05-12 9:29 ` Alex Bennée
2023-05-19 1:16 ` Wu, Fei
2023-05-19 22:01 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421132421.1617479-1-fei2.wu@intel.com \
--to=fei2.wu@intel.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).