From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: <qemu-devel@nongnu.org>, "Michael S . Tsirkin" <mst@redhat.com>
Cc: "Fan Ni" <fan.ni@samsung.com>,
linuxarm@huawei.com, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dave Jiang" <dave.jiang@intel.com>,
linux-cxl@vger.kernel.org
Subject: [PATCH v2 0/3] hw/cxl: Fix decoder commit and uncommit handling
Date: Fri, 21 Apr 2023 14:59:03 +0100 [thread overview]
Message-ID: <20230421135906.3515-1-Jonathan.Cameron@huawei.com> (raw)
v2:
- Split dropping the transaction guards out as precursor (Phillipe)
- Picked up tags
Issue reported in discussion of:
https://lore.kernel.org/all/20230228224014.1402545-1-fan.ni@samsung.com/
The committed bit for HDM decoders is expected reset when commit transitions
from 1->0. Whilst looking at that it was noticed that hardware was resetting
the commit bit which is not an option allowed by the CXL spec.
In common with many other areas the code did not take into account
big endian architectures, so fix that whilst we are here.
Note testing this exposed a kernel bug around repeated attempts to clear
a decoder out of order. That's been reported but not yet fixed.
Jonathan Cameron (3):
hw/cxl: drop pointless memory_region_transaction_guards
hw/cxl: Fix endian handling for decoder commit.
hw/cxl: Fix incorrect reset of commit and associated clearing of
committed.
hw/cxl/cxl-component-utils.c | 14 ++++++++------
hw/mem/cxl_type3.c | 28 +++++++++++++++++++++++++---
2 files changed, 33 insertions(+), 9 deletions(-)
--
2.37.2
next reply other threads:[~2023-04-21 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 13:59 Jonathan Cameron via [this message]
2023-04-21 13:59 ` [PATCH v2 1/3] hw/cxl: drop pointless memory_region_transaction_guards Jonathan Cameron via
2023-04-21 13:59 ` [PATCH v2 2/3] hw/cxl: Fix endian handling for decoder commit Jonathan Cameron via
2023-04-21 13:59 ` [PATCH v2 3/3] hw/cxl: Fix incorrect reset of commit and associated clearing of committed Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421135906.3515-1-Jonathan.Cameron@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dave.jiang@intel.com \
--cc=fan.ni@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).