qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: qemu-devel@nongnu.org
Cc: "Thomas Weißschuh" <thomas@t-8ch.de>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PATCH v2 2/2] linux-user: Don't require PROT_READ for mincore
Date: Sat, 22 Apr 2023 12:03:14 +0200	[thread overview]
Message-ID: <20230422100314.1650-3-thomas@t-8ch.de> (raw)
In-Reply-To: <20230422100314.1650-1-thomas@t-8ch.de>

The kernel does not require PROT_READ for addresses passed to mincore.
For example the fincore(1) tool from util-linux uses PROT_NONE and
currently does not work under qemu-user.

Example (with fincore(1) from util-linux 2.38):

$ fincore /proc/self/exe
RES PAGES  SIZE FILE
24K     6 22.1K /proc/self/exe

$ qemu-x86_64 /usr/bin/fincore /proc/self/exe
fincore: failed to do mincore: /proc/self/exe: Cannot allocate memory

With this patch:

$ ./build/qemu-x86_64 /usr/bin/fincore /proc/self/exe
RES PAGES  SIZE FILE
24K     6 22.1K /proc/self/exe

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 69f740ff98c8..5ec848b459f7 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11897,7 +11897,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
 #ifdef TARGET_NR_mincore
     case TARGET_NR_mincore:
         {
-            void *a = lock_user(VERIFY_READ, arg1, arg2, 0);
+            void *a = lock_user(VERIFY_NONE, arg1, arg2, 0);
             if (!a) {
                 return -TARGET_ENOMEM;
             }
-- 
2.40.0



  parent reply	other threads:[~2023-04-22 10:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-22 10:03 [PATCH v2 0/2] linux-user: Fix mincore() with PROT_NONE Thomas Weißschuh
2023-04-22 10:03 ` [PATCH v2 1/2] linux-user: Add new flag VERIFY_NONE Thomas Weißschuh
2023-05-01 15:48   ` Laurent Vivier
2023-05-01 15:54   ` Laurent Vivier
2023-04-22 10:03 ` Thomas Weißschuh [this message]
2023-05-01 15:48   ` [PATCH v2 2/2] linux-user: Don't require PROT_READ for mincore Laurent Vivier
2023-05-01 15:54   ` Laurent Vivier
2023-04-23 17:24 ` [PATCH v2 0/2] linux-user: Fix mincore() with PROT_NONE Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230422100314.1650-3-thomas@t-8ch.de \
    --to=thomas@t-8ch.de \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).