From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v4 0/5] parallels: Add duplication check, repair at open, fix bugs
Date: Mon, 24 Apr 2023 11:43:04 +0200 [thread overview]
Message-ID: <20230424094309.197969-1-alexander.ivanov@virtuozzo.com> (raw)
This patchset should be applied on the top of [PATCH v10 00/12] parallels:
Refactor the code of images checks and fix a bug.
Fix incorrect data end calculation in parallels_open().
Split image leak handling to separate check and fix helpers.
Add checking and repairing duplicate offsets in BAT
Replace fprintf() by qemu_log().
Image repairing in parallels_open().
v4:
2,5: Rebased.
v3:
2: Added (size >= res->image_end_offset) assert and changed the comment in
parallels_get_leak_size(). Changed error printing and leaks fixing order.
3: Removed highest_offset() helper, instead image_end_offset field is used.
5: Moved highest_offset() code to parallels_open() - now it is used only in
this function. Fixed data_end update condition. Fixed a leak of
s->migration_blocker.
v2:
2: Moved outsude parallels_check_leak() 2 helpers:
parallels_get_leak_size() and parallels_fix_leak().
3: Used highest_offset() helper in parallels_check_leak(). Fixed a typo.
Added comments. Replaced g_malloc() call by qemu_memalign(). Replaced
bdrv_pread() call by bdrv_co_pread(). Got rid of keeping bytes and
sectors in the same variable. Added setting the bitmap of the used
clusters for a new allocated cluster if it isn't out of the bitmap.
Moved the leak fix to the end of all the checks. Removed a dependence
on image format for the duplicate check.
4 (old): Merged this patch to the previous.
4 (former 5): Fixed formatting.
5 (former 6): Fixed comments. Added O_INACTIVE check in the condition.
Replaced inuse detection by header_unclean checking.
Replaced playing with corutines by bdrv_check() usage.
Alexander Ivanov (5):
parallels: Incorrect data end calculation in parallels_open()
parallels: Split image leak handling to separate check and fix helpers
parallels: Add checking and repairing duplicate offsets in BAT
parallels: Replace fprintf by qemu_log in check
parallels: Image repairing in parallels_open()
block/parallels.c | 291 ++++++++++++++++++++++++++++++++++++----------
1 file changed, 228 insertions(+), 63 deletions(-)
--
2.34.1
next reply other threads:[~2023-04-24 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 9:43 Alexander Ivanov [this message]
2023-04-24 9:43 ` [PATCH v4 1/5] parallels: Incorrect data end calculation in parallels_open() Alexander Ivanov
2023-04-24 9:43 ` [PATCH v4 2/5] parallels: Split image leak handling to separate check and fix helpers Alexander Ivanov
2023-04-24 9:43 ` [PATCH v4 3/5] parallels: Add checking and repairing duplicate offsets in BAT Alexander Ivanov
2023-04-26 21:56 ` Mike Maslenkin
2023-04-27 12:29 ` Alexander Ivanov
2023-04-28 22:15 ` Mike Maslenkin
2023-05-04 12:47 ` Alexander Ivanov
2023-04-27 13:46 ` Mike Maslenkin
2023-04-28 11:48 ` Alexander Ivanov
2023-04-24 9:43 ` [PATCH v4 4/5] parallels: Replace fprintf by qemu_log in check Alexander Ivanov
2023-04-24 9:43 ` [PATCH v4 5/5] parallels: Image repairing in parallels_open() Alexander Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424094309.197969-1-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).