From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Eric Blake" <eblake@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>
Subject: [PULL 18/30] migration: Move migrate_cap_set() to options.c
Date: Mon, 24 Apr 2023 15:27:18 +0200 [thread overview]
Message-ID: <20230424132730.70752-19-quintela@redhat.com> (raw)
In-Reply-To: <20230424132730.70752-1-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
migration/migration.c | 20 --------------------
migration/options.c | 21 +++++++++++++++++++++
migration/options.h | 1 +
3 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index b198f4acf5..ddd3fc361f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1666,26 +1666,6 @@ void migrate_set_state(int *state, int old_state, int new_state)
}
}
-static bool migrate_cap_set(int cap, bool value, Error **errp)
-{
- MigrationState *s = migrate_get_current();
- bool new_caps[MIGRATION_CAPABILITY__MAX];
-
- if (migration_is_running(s->state)) {
- error_setg(errp, QERR_MIGRATION_ACTIVE);
- return false;
- }
-
- memcpy(new_caps, s->capabilities, sizeof(new_caps));
- new_caps[cap] = value;
-
- if (!migrate_caps_check(s->capabilities, new_caps, errp)) {
- return false;
- }
- s->capabilities[cap] = value;
- return true;
-}
-
static void migrate_set_block_incremental(MigrationState *s, bool value)
{
s->parameters.block_incremental = value;
diff --git a/migration/options.c b/migration/options.c
index 4cbe77e35a..f3b2d6e482 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -14,6 +14,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qapi/qapi-commands-migration.h"
+#include "qapi/qmp/qerror.h"
#include "sysemu/runstate.h"
#include "migration.h"
#include "ram.h"
@@ -392,6 +393,26 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp)
return true;
}
+bool migrate_cap_set(int cap, bool value, Error **errp)
+{
+ MigrationState *s = migrate_get_current();
+ bool new_caps[MIGRATION_CAPABILITY__MAX];
+
+ if (migration_is_running(s->state)) {
+ error_setg(errp, QERR_MIGRATION_ACTIVE);
+ return false;
+ }
+
+ memcpy(new_caps, s->capabilities, sizeof(new_caps));
+ new_caps[cap] = value;
+
+ if (!migrate_caps_check(s->capabilities, new_caps, errp)) {
+ return false;
+ }
+ s->capabilities[cap] = value;
+ return true;
+}
+
MigrationCapabilityStatusList *qmp_query_migrate_capabilities(Error **errp)
{
MigrationCapabilityStatusList *head = NULL, **tail = &head;
diff --git a/migration/options.h b/migration/options.h
index e779f14161..5979e4ff90 100644
--- a/migration/options.h
+++ b/migration/options.h
@@ -41,5 +41,6 @@ bool migrate_zero_copy_send(void);
/* capabilities helpers */
bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp);
+bool migrate_cap_set(int cap, bool value, Error **errp);
#endif
--
2.39.2
next prev parent reply other threads:[~2023-04-24 13:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:27 [PULL 00/30] Migration 20230424 patches Juan Quintela
2023-04-24 13:27 ` [PULL 01/30] migration: Minor control flow simplification Juan Quintela
2023-04-24 13:27 ` [PULL 02/30] migration: move migration_global_dump() to migration-hmp-cmds.c Juan Quintela
2023-04-24 13:27 ` [PULL 03/30] spice: move client_migrate_info command to ui/ Juan Quintela
2023-04-24 13:27 ` [PULL 04/30] migration: Create migrate_cap_set() Juan Quintela
2023-04-24 13:27 ` [PULL 05/30] migration: Create options.c Juan Quintela
2023-04-24 13:27 ` [PULL 06/30] migration: Move migrate_colo_enabled() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 07/30] migration: Move migrate_use_compression() " Juan Quintela
2023-04-24 13:27 ` [PULL 08/30] migration: Move migrate_use_events() " Juan Quintela
2023-04-24 13:27 ` [PULL 09/30] migration: Move migrate_use_multifd() " Juan Quintela
2023-04-24 13:27 ` [PULL 10/30] migration: Move migrate_use_zero_copy_send() " Juan Quintela
2023-04-24 13:27 ` [PULL 11/30] migration: Move migrate_use_xbzrle() " Juan Quintela
2023-04-24 13:27 ` [PULL 12/30] migration: Move migrate_use_block() " Juan Quintela
2023-04-24 13:27 ` [PULL 13/30] migration: Move migrate_use_return() " Juan Quintela
2023-04-24 13:27 ` [PULL 14/30] migration: Create migrate_rdma_pin_all() function Juan Quintela
2023-04-24 13:27 ` [PULL 15/30] migration: Move migrate_caps_check() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 16/30] migration: Move qmp_query_migrate_capabilities() " Juan Quintela
2023-04-24 13:27 ` [PULL 17/30] migration: Move qmp_migrate_set_capabilities() " Juan Quintela
2023-04-24 13:27 ` Juan Quintela [this message]
2023-04-24 13:27 ` [PULL 19/30] migration: Move parameters functions to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 20/30] migration: Use migrate_max_postcopy_bandwidth() Juan Quintela
2023-04-24 13:27 ` [PULL 21/30] migration: Move migrate_use_block_incremental() to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 22/30] migration: Create migrate_throttle_trigger_threshold() Juan Quintela
2023-04-24 13:27 ` [PULL 23/30] migration: Create migrate_checkpoint_delay() Juan Quintela
2023-04-24 13:27 ` [PULL 24/30] migration: Create migrate_max_cpu_throttle() Juan Quintela
2023-04-24 13:27 ` [PULL 25/30] migration: Move migrate_announce_params() to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 26/30] migration: Create migrate_cpu_throttle_initial() " Juan Quintela
2023-04-24 13:27 ` [PULL 27/30] migration: Create migrate_cpu_throttle_increment() function Juan Quintela
2023-04-24 13:27 ` [PULL 28/30] migration: Create migrate_cpu_throttle_tailslow() function Juan Quintela
2023-04-24 13:27 ` [PULL 29/30] migration: Move migrate_postcopy() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 30/30] migration: Create migrate_max_bandwidth() function Juan Quintela
2023-04-24 16:35 ` [PULL 00/30] Migration 20230424 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424132730.70752-19-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).