From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Eric Blake" <eblake@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>
Subject: [PULL 08/30] migration: Move migrate_use_events() to options.c
Date: Mon, 24 Apr 2023 15:27:08 +0200 [thread overview]
Message-ID: <20230424132730.70752-9-quintela@redhat.com> (raw)
In-Reply-To: <20230424132730.70752-1-quintela@redhat.com>
Once that we are there, we rename the function to migrate_events()
to be consistent with all other capabilities.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
migration/migration.c | 11 +----------
migration/migration.h | 1 -
migration/options.c | 9 +++++++++
migration/options.h | 1 +
migration/ram.c | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 2c409fa27c..16800a624a 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -353,7 +353,7 @@ void migration_incoming_state_destroy(void)
static void migrate_generate_event(int new_state)
{
- if (migrate_use_events()) {
+ if (migrate_events()) {
qapi_event_send_migration(new_state);
}
}
@@ -2558,15 +2558,6 @@ int migrate_decompress_threads(void)
return s->parameters.decompress_threads;
}
-bool migrate_use_events(void)
-{
- MigrationState *s;
-
- s = migrate_get_current();
-
- return s->capabilities[MIGRATION_CAPABILITY_EVENTS];
-}
-
bool migrate_use_multifd(void)
{
MigrationState *s;
diff --git a/migration/migration.h b/migration/migration.h
index 77aa91c840..bd06520c19 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -475,7 +475,6 @@ int migrate_compress_level(void);
int migrate_compress_threads(void);
int migrate_compress_wait_thread(void);
int migrate_decompress_threads(void);
-bool migrate_use_events(void);
/* Sending on the return path - generic and then for each message type */
void migrate_send_rp_shut(MigrationIncomingState *mis,
diff --git a/migration/options.c b/migration/options.c
index fa7a13d3dc..d2219ee0e4 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -57,6 +57,15 @@ bool migrate_dirty_bitmaps(void)
return s->capabilities[MIGRATION_CAPABILITY_DIRTY_BITMAPS];
}
+bool migrate_events(void)
+{
+ MigrationState *s;
+
+ s = migrate_get_current();
+
+ return s->capabilities[MIGRATION_CAPABILITY_EVENTS];
+}
+
bool migrate_ignore_shared(void)
{
MigrationState *s;
diff --git a/migration/options.h b/migration/options.h
index da2193fd94..b998024eba 100644
--- a/migration/options.h
+++ b/migration/options.h
@@ -21,6 +21,7 @@ bool migrate_background_snapshot(void);
bool migrate_colo(void);
bool migrate_compress(void);
bool migrate_dirty_bitmaps(void);
+bool migrate_events(void);
bool migrate_ignore_shared(void);
bool migrate_late_block_activate(void);
bool migrate_pause_before_switchover(void);
diff --git a/migration/ram.c b/migration/ram.c
index d050d0c5fd..ee454a3849 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1246,7 +1246,7 @@ static void migration_bitmap_sync(RAMState *rs)
rs->num_dirty_pages_period = 0;
rs->bytes_xfer_prev = stat64_get(&ram_counters.transferred);
}
- if (migrate_use_events()) {
+ if (migrate_events()) {
uint64_t generation = stat64_get(&ram_counters.dirty_sync_count);
qapi_event_send_migration_pass(generation);
}
--
2.39.2
next prev parent reply other threads:[~2023-04-24 13:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:27 [PULL 00/30] Migration 20230424 patches Juan Quintela
2023-04-24 13:27 ` [PULL 01/30] migration: Minor control flow simplification Juan Quintela
2023-04-24 13:27 ` [PULL 02/30] migration: move migration_global_dump() to migration-hmp-cmds.c Juan Quintela
2023-04-24 13:27 ` [PULL 03/30] spice: move client_migrate_info command to ui/ Juan Quintela
2023-04-24 13:27 ` [PULL 04/30] migration: Create migrate_cap_set() Juan Quintela
2023-04-24 13:27 ` [PULL 05/30] migration: Create options.c Juan Quintela
2023-04-24 13:27 ` [PULL 06/30] migration: Move migrate_colo_enabled() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 07/30] migration: Move migrate_use_compression() " Juan Quintela
2023-04-24 13:27 ` Juan Quintela [this message]
2023-04-24 13:27 ` [PULL 09/30] migration: Move migrate_use_multifd() " Juan Quintela
2023-04-24 13:27 ` [PULL 10/30] migration: Move migrate_use_zero_copy_send() " Juan Quintela
2023-04-24 13:27 ` [PULL 11/30] migration: Move migrate_use_xbzrle() " Juan Quintela
2023-04-24 13:27 ` [PULL 12/30] migration: Move migrate_use_block() " Juan Quintela
2023-04-24 13:27 ` [PULL 13/30] migration: Move migrate_use_return() " Juan Quintela
2023-04-24 13:27 ` [PULL 14/30] migration: Create migrate_rdma_pin_all() function Juan Quintela
2023-04-24 13:27 ` [PULL 15/30] migration: Move migrate_caps_check() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 16/30] migration: Move qmp_query_migrate_capabilities() " Juan Quintela
2023-04-24 13:27 ` [PULL 17/30] migration: Move qmp_migrate_set_capabilities() " Juan Quintela
2023-04-24 13:27 ` [PULL 18/30] migration: Move migrate_cap_set() " Juan Quintela
2023-04-24 13:27 ` [PULL 19/30] migration: Move parameters functions to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 20/30] migration: Use migrate_max_postcopy_bandwidth() Juan Quintela
2023-04-24 13:27 ` [PULL 21/30] migration: Move migrate_use_block_incremental() to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 22/30] migration: Create migrate_throttle_trigger_threshold() Juan Quintela
2023-04-24 13:27 ` [PULL 23/30] migration: Create migrate_checkpoint_delay() Juan Quintela
2023-04-24 13:27 ` [PULL 24/30] migration: Create migrate_max_cpu_throttle() Juan Quintela
2023-04-24 13:27 ` [PULL 25/30] migration: Move migrate_announce_params() to option.c Juan Quintela
2023-04-24 13:27 ` [PULL 26/30] migration: Create migrate_cpu_throttle_initial() " Juan Quintela
2023-04-24 13:27 ` [PULL 27/30] migration: Create migrate_cpu_throttle_increment() function Juan Quintela
2023-04-24 13:27 ` [PULL 28/30] migration: Create migrate_cpu_throttle_tailslow() function Juan Quintela
2023-04-24 13:27 ` [PULL 29/30] migration: Move migrate_postcopy() to options.c Juan Quintela
2023-04-24 13:27 ` [PULL 30/30] migration: Create migrate_max_bandwidth() function Juan Quintela
2023-04-24 16:35 ` [PULL 00/30] Migration 20230424 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424132730.70752-9-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).