From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org, pbonzini@redhat.com,
mtosatti@redhat.com, danielhb413@gmail.com, clg@kaod.org,
david@gibson.dropbear.id.au, groug@kaod.org,
peter.maydell@linaro.org, chenhuacai@kernel.org,
pasic@linux.ibm.com, borntraeger@linux.ibm.com
Subject: Re: [PATCH] kvm: Merge kvm_check_extension() and kvm_vm_check_extension()
Date: Tue, 25 Apr 2023 09:51:42 +0100 [thread overview]
Message-ID: <20230425085142.GA976713@myrica> (raw)
In-Reply-To: <87jzy1v3gd.fsf@redhat.com>
On Mon, Apr 24, 2023 at 03:01:54PM +0200, Cornelia Huck wrote:
> > @@ -2480,6 +2471,7 @@ static int kvm_init(MachineState *ms)
> > }
> >
> > s->vmfd = ret;
> > + s->check_extension_vm = kvm_check_extension(s, KVM_CAP_CHECK_EXTENSION_VM);
>
> Hm, it's a bit strange to set s->check_extension_vm by calling a
> function that already checks for the value of
> s->check_extension_vm... would it be better to call kvm_ioctl() directly
> on this line?
Yes that's probably best. I'll use kvm_vm_ioctl() since the doc suggests
to check KVM_CAP_CHECK_EXTENSION_VM on the vm fd.
Thanks,
Jean
>
> I think it would be good if some ppc folks could give this a look, but
> in general, it looks fine to me.
>
prev parent reply other threads:[~2023-04-25 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 16:38 [PATCH] kvm: Merge kvm_check_extension() and kvm_vm_check_extension() Jean-Philippe Brucker
2023-04-24 13:01 ` Cornelia Huck
2023-04-25 8:51 ` Jean-Philippe Brucker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425085142.GA976713@myrica \
--to=jean-philippe@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).