qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [RFC PATCH 0/3] Deprecate the qemu-system-i386 binary
Date: Tue, 25 Apr 2023 15:38:48 +0200	[thread overview]
Message-ID: <20230425133851.489283-1-thuth@redhat.com> (raw)

Allow running qemu-system-x86_64 in 32-bit-only mode (by renaming
or symlinking the binary to "qemu-system-i386"). After doing this,
qemu-system-x86_64 should be a proper superset of qemu-system-i386
(apart from 32-bit KVM support, which however is not really required
anymore, see https://lore.kernel.org/kvm/Y%2ffkTs5ajFy0hP1U@google.com/ ).
Thus we can finally deprecate the qemu-system-i386 binary. This will
help to avoid that we have to compile a lot of the x86 stuff twice
once we'll finally be able to drop qemu-system-i386.

Marked as RFC since there are likely still a bunch of spots around
that need attention, e.g.:

- CPU types have different suffixes between the -x86_64 and -i386
  variant (see TYPE_X86_CPU in cpu-qom.h) ... do we need to care
  about this in the new qemu-system-i386 symlink run mode?

- The code in target/i386/tcg/sysemu/smm_helper.c looks like it
  maybe needs a runtime switch, too ... or is it ok to leave this
  hard-coded to the x86_64 version?

Anyway, I'd like to get some feedback on this idea here... What
do you think of the idea of getting rid of the qemu-system-i386
binary this way in the future?

Thomas Huth (3):
  cpu: Add a way to detect 32-bit mode from argv0
  target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode only
  docs/about/deprecated: Deprecate the qemu-system-i386 binary

 docs/about/deprecated.rst | 16 ++++++++++++++++
 include/hw/core/cpu.h     | 10 ++++++++++
 target/i386/cpu.h         |  4 ++--
 cpu.c                     | 13 +++++++++++++
 softmmu/vl.c              |  1 +
 target/i386/cpu.c         | 28 +++++++++++++---------------
 target/i386/gdbstub.c     |  8 +-------
 7 files changed, 56 insertions(+), 24 deletions(-)

-- 
2.31.1



             reply	other threads:[~2023-04-25 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 13:38 Thomas Huth [this message]
2023-04-25 13:38 ` [RFC PATCH 1/3] cpu: Add a way to detect 32-bit mode from argv0 Thomas Huth
2023-04-25 13:38 ` [RFC PATCH 2/3] target/i386/cpu: Allow to limit the 64-bit binary to 32-bit mode only Thomas Huth
2023-04-25 13:38 ` [RFC PATCH 3/3] docs/about/deprecated: Deprecate the qemu-system-i386 binary Thomas Huth
2023-10-06  9:38   ` Philippe Mathieu-Daudé
2023-04-26 10:59 ` [RFC PATCH 0/3] " Paolo Bonzini
2023-04-27  8:13   ` Thomas Huth
2023-04-27  8:25     ` Paolo Bonzini
2023-04-27  8:28   ` Daniel P. Berrangé
2023-04-27  8:31     ` Paolo Bonzini
2023-04-27  8:33       ` Daniel P. Berrangé
2023-04-27  9:06         ` Paolo Bonzini
2023-04-27 12:12         ` Thomas Huth
2023-04-27 12:22           ` Daniel P. Berrangé
2024-06-19 10:09   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425133851.489283-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).