qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER
@ 2023-04-26  0:40 Taylor Simpson
  2023-04-26 17:32 ` Richard Henderson
  0 siblings, 1 reply; 3+ messages in thread
From: Taylor Simpson @ 2023-04-26  0:40 UTC (permalink / raw)
  To: qemu-devel
  Cc: tsimpson, richard.henderson, philmd, ale, anjo, bcain,
	quic_mathbern, pbonzini, marcandre.lureau, berrange, thuth

Enable conditional compilation depending on whether idef-parser
is configured

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index c44d05a13f..d4e438b033 100644
--- a/meson.build
+++ b/meson.build
@@ -1859,6 +1859,7 @@ endif
 config_host_data.set('CONFIG_GTK', gtk.found())
 config_host_data.set('CONFIG_VTE', vte.found())
 config_host_data.set('CONFIG_GTK_CLIPBOARD', have_gtk_clipboard)
+config_host_data.set('CONFIG_HEXAGON_IDEF_PARSER', get_option('hexagon_idef_parser'))
 config_host_data.set('CONFIG_LIBATTR', have_old_libattr)
 config_host_data.set('CONFIG_LIBCAP_NG', libcap_ng.found())
 config_host_data.set('CONFIG_EBPF', libbpf.found())
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER
  2023-04-26  0:40 [PATCH 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER Taylor Simpson
@ 2023-04-26 17:32 ` Richard Henderson
  2023-04-26 17:34   ` Taylor Simpson
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2023-04-26 17:32 UTC (permalink / raw)
  To: Taylor Simpson, qemu-devel
  Cc: philmd, ale, anjo, bcain, quic_mathbern, pbonzini,
	marcandre.lureau, berrange, thuth

On 4/26/23 01:40, Taylor Simpson wrote:
> Enable conditional compilation depending on whether idef-parser
> is configured
> 
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)

Are you not at the point where you want this unconditionally?
How long do you intend to keep this optional?


r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER
  2023-04-26 17:32 ` Richard Henderson
@ 2023-04-26 17:34   ` Taylor Simpson
  0 siblings, 0 replies; 3+ messages in thread
From: Taylor Simpson @ 2023-04-26 17:34 UTC (permalink / raw)
  To: Richard Henderson, qemu-devel@nongnu.org
  Cc: philmd@linaro.org, ale@rev.ng, anjo@rev.ng, Brian Cain,
	Matheus Bernardino (QUIC), pbonzini@redhat.com,
	marcandre.lureau@redhat.com, berrange@redhat.com,
	thuth@redhat.com



> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Wednesday, April 26, 2023 12:32 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@linaro.org; ale@rev.ng; anjo@rev.ng; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; pbonzini@redhat.com;
> marcandre.lureau@redhat.com; berrange@redhat.com; thuth@redhat.com
> Subject: Re: [PATCH 01/21] meson.build Add
> CONFIG_HEXAGON_IDEF_PARSER
> 
> On 4/26/23 01:40, Taylor Simpson wrote:
> > Enable conditional compilation depending on whether idef-parser is
> > configured
> >
> > Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> > ---
> >   meson.build | 1 +
> >   1 file changed, 1 insertion(+)
> 
> Are you not at the point where you want this unconditionally?
> How long do you intend to keep this optional?

The default is ON, but we want to keep the OFF option working.

Thanks,
Taylor


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-26 17:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-26  0:40 [PATCH 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER Taylor Simpson
2023-04-26 17:32 ` Richard Henderson
2023-04-26 17:34   ` Taylor Simpson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).