qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Cleber Rosa <crosa@redhat.com>,
	Juan Quintela <quintela@redhat.com>, John Snow <jsnow@redhat.com>,
	Leonardo Bras <leobras@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [PULL 1/7] migration: Disable postcopy + multifd migration
Date: Wed, 26 Apr 2023 20:12:47 +0200	[thread overview]
Message-ID: <20230426181253.13286-2-quintela@redhat.com> (raw)
In-Reply-To: <20230426181253.13286-1-quintela@redhat.com>

From: Leonardo Bras <leobras@redhat.com>

Since the introduction of multifd, it's possible to perform a multifd
migration and finish it using postcopy.

A bug introduced by yank (fixed on cfc3bcf373) was previously preventing
a successful use of this migration scenario, and now thing should be
working on most scenarios.

But since there is not enough testing/support nor any reported users for
this scenario, we should disable this combination before it may cause any
problems for users.

Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/options.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/migration/options.c b/migration/options.c
index 8e8753d9be..dd97c99391 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -322,6 +322,11 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp)
             error_setg(errp, "Postcopy is not compatible with ignore-shared");
             return false;
         }
+
+        if (new_caps[MIGRATION_CAPABILITY_MULTIFD]) {
+            error_setg(errp, "Postcopy is not yet compatible with multifd");
+            return false;
+        }
     }
 
     if (new_caps[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT]) {
-- 
2.40.0



  reply	other threads:[~2023-04-26 18:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 18:12 [PULL 0/7] Migration 20230426 patches Juan Quintela
2023-04-26 18:12 ` Juan Quintela [this message]
2023-04-26 18:12 ` [PULL 2/7] MAINTAINERS: Add Leonardo and Peter as reviewers Juan Quintela
2023-04-26 18:12 ` [PULL 3/7] migration: Move migrate_use_tls() to options.c Juan Quintela
2023-04-26 18:12 ` [PULL 4/7] migration: Move qmp_migrate_set_parameters() " Juan Quintela
2023-04-26 18:12 ` [PULL 5/7] migration: Allow postcopy_ram_supported_by_host() to report err Juan Quintela
2023-04-26 18:12 ` [PULL 6/7] migration/vmstate-dump: Dump array size too as "num" Juan Quintela
2023-04-26 18:12 ` [PULL 7/7] vmstate-static-checker: Recognize "num" field Juan Quintela
2023-04-27  7:51 ` [PULL 0/7] Migration 20230426 patches Richard Henderson
2023-04-27  8:19   ` Juan Quintela
  -- strict thread matches above, loose matches on Subject: below --
2023-04-27  8:25 Juan Quintela
2023-04-27  8:25 ` [PULL 1/7] migration: Disable postcopy + multifd migration Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230426181253.13286-2-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=crosa@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).