From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 0/2] target/s390x: Fix EXECUTE of relative branches
Date: Thu, 27 Apr 2023 01:58:11 +0200 [thread overview]
Message-ID: <20230426235813.198183-1-iii@linux.ibm.com> (raw)
Hi,
This series fixes EXECUTing relative branches: currently the offset is
incorrectly applied to EXECUTE and not the branch itself. This is
similar to what I previously fixed for load/store instructions.
Unfortunately here it's not feaisble to use the ri2 field, since it
would break the direct branch optimization. Instead, introduce the
disas_jdest() macro and pass its output to help_branch().
Patch 1 is the fix, patch 2 is the test.
Best regards,
Ilya
Ilya Leoshkevich (2):
target/s390x: Fix EXECUTE of relative branches
tests/tcg/s390x: Test EXECUTE of relative branches
target/s390x/tcg/translate.c | 81 +++++++++++-----
tests/tcg/s390x/Makefile.target | 1 +
tests/tcg/s390x/ex-branch.c | 158 ++++++++++++++++++++++++++++++++
3 files changed, 217 insertions(+), 23 deletions(-)
create mode 100644 tests/tcg/s390x/ex-branch.c
--
2.40.0
next reply other threads:[~2023-04-26 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 23:58 Ilya Leoshkevich [this message]
2023-04-26 23:58 ` [PATCH 1/2] target/s390x: Fix EXECUTE of relative branches Ilya Leoshkevich
2023-04-27 12:38 ` Richard Henderson
2023-04-26 23:58 ` [PATCH 2/2] tests/tcg/s390x: Test " Ilya Leoshkevich
2023-04-27 12:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426235813.198183-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).