qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, "Yohei Kojima" <y-koj@outlook.jp>,
	"Juan Quintela" <quintela@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 14/18] qemu-options.hx: Update descriptions of memory options for NUMA node
Date: Thu, 27 Apr 2023 16:45:06 +0100	[thread overview]
Message-ID: <20230427154510.1791273-15-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230427154510.1791273-1-alex.bennee@linaro.org>

From: Yohei Kojima <y-koj@outlook.jp>

This commit adds the following description:
1. `memdev` option is recommended over `mem` option (see [1,2])
2. users must specify memory for all NUMA nodes (see [2])

This commit also separates descriptions for `mem` and `memdev` into two
paragraphs. The old doc describes legacy `mem` option first, and it was
a bit confusing.

Related documentation:
[1] https://wiki.qemu.org/ChangeLog/5.1#Incompatible_changes
[2] https://www.qemu.org/docs/master/about/removed-features.html

Signed-off-by: Yohei Kojima <y-koj@outlook.jp>
Message-Id: <TYZPR06MB5418D6B0175A49E8E76988439D8E9@TYZPR06MB5418.apcprd06.prod.outlook.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[AJB: fix documentation in commit message]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230424092249.58552-15-alex.bennee@linaro.org>

diff --git a/qemu-options.hx b/qemu-options.hx
index baa0589733..b5efa648ba 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -405,15 +405,22 @@ SRST
         -numa node,nodeid=0 -numa node,nodeid=1 \
         -numa cpu,node-id=0,socket-id=0 -numa cpu,node-id=1,socket-id=1
 
-    Legacy '\ ``mem``\ ' assigns a given RAM amount to a node (not supported
-    for 5.1 and newer machine types). '\ ``memdev``\ ' assigns RAM from
-    a given memory backend device to a node. If '\ ``mem``\ ' and
-    '\ ``memdev``\ ' are omitted in all nodes, RAM is split equally between them.
-
-
-    '\ ``mem``\ ' and '\ ``memdev``\ ' are mutually exclusive.
-    Furthermore, if one node uses '\ ``memdev``\ ', all of them have to
-    use it.
+    '\ ``memdev``\ ' option assigns RAM from a given memory backend
+    device to a node. It is recommended to use '\ ``memdev``\ ' option
+    over legacy '\ ``mem``\ ' option. This is because '\ ``memdev``\ '
+    option provides better performance and more control over the
+    backend's RAM (e.g. '\ ``prealloc``\ ' parameter of
+    '\ ``-memory-backend-ram``\ ' allows memory preallocation).
+
+    For compatibility reasons, legacy '\ ``mem``\ ' option is
+    supported in 5.0 and older machine types. Note that '\ ``mem``\ '
+    and '\ ``memdev``\ ' are mutually exclusive. If one node uses
+    '\ ``memdev``\ ', the rest nodes have to use '\ ``memdev``\ '
+    option, and vice versa.
+
+    Users must specify memory for all NUMA nodes by '\ ``memdev``\ '
+    (or legacy '\ ``mem``\ ' if available). In QEMU 5.2, the support
+    for '\ ``-numa node``\ ' without memory specified was removed.
 
     '\ ``initiator``\ ' is an additional option that points to an
     initiator NUMA node that has best performance (the lowest latency or
-- 
2.39.2



  parent reply	other threads:[~2023-04-27 15:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 15:44 [PULL 00/18] testing and doc updates Alex Bennée
2023-04-27 15:44 ` [PULL 01/18] tests/requirements.txt: bump up avocado-framework version to 101.0 Alex Bennée
2023-04-27 15:44 ` [PULL 02/18] tests/avocado: use the new snapshots for testing Alex Bennée
2023-04-28 12:08   ` Thomas Huth
2023-04-28 16:43     ` Alex Bennée
2023-04-27 15:44 ` [PULL 03/18] tests/avocado: Add set of boot tests on SBSA-ref Alex Bennée
2023-04-28 10:33   ` Thomas Huth
2023-07-10 12:10     ` Thomas Huth
2023-04-27 15:44 ` [PULL 04/18] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs Alex Bennée
2023-04-27 15:44 ` [PULL 05/18] scripts/device-crash-test: Add a parameter to run with TCG only Alex Bennée
2023-04-27 15:44 ` [PULL 06/18] qemu-options: finesse the recommendations around -blockdev Alex Bennée
2023-04-27 15:44 ` [PULL 07/18] .gitlab-ci.d/cirrus: Drop the CI job for compiling with FreeBSD 12 Alex Bennée
2023-04-27 15:45 ` [PULL 08/18] tests/avocado: Make ssh_command_output_contains() globally available Alex Bennée
2023-04-27 15:45 ` [PULL 09/18] tests/avocado/machine_aspeed: Fix the broken ast2[56]00_evb_sdk tests Alex Bennée
2023-04-27 15:45 ` [PULL 10/18] MAINTAINERS: Cover tests/avocado/machine_aspeed.py Alex Bennée
2023-04-27 15:45 ` [PULL 11/18] avocado_qemu/__init__.py: factor out the qemu-img finding Alex Bennée
2023-04-27 15:45 ` [PULL 12/18] tests/avocado/tuxrun_baselines.py: improve code coverage for ppc64 Alex Bennée
2023-04-27 15:45 ` [PULL 13/18] tests/tcg: limit the scope of the plugin tests Alex Bennée
2023-04-27 15:45 ` Alex Bennée [this message]
2023-04-27 15:45 ` [PULL 15/18] docs/system: remove excessive punctuation from guest-loader docs Alex Bennée
2023-04-27 15:45 ` [PULL 16/18] docs/devel: make a statement about includes Alex Bennée
2023-04-27 15:45 ` [PULL 17/18] docs/devel: mention the spacing requirement for QOM Alex Bennée
2023-04-27 15:45 ` [PULL 18/18] docs/style: call out the use of GUARD macros Alex Bennée
2023-04-28  7:34 ` [PULL 00/18] testing and doc updates Richard Henderson
2023-05-02 11:46 ` Peter Maydell
2023-05-02 12:21   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427154510.1791273-15-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=y-koj@outlook.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).