qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Thomas Huth" <thuth@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 17/18] docs/devel: mention the spacing requirement for QOM
Date: Thu, 27 Apr 2023 16:45:09 +0100	[thread overview]
Message-ID: <20230427154510.1791273-18-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230427154510.1791273-1-alex.bennee@linaro.org>

We have a more complete document on QOM but we should at least mention
the style requirements in the style guide.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20230424092249.58552-18-alex.bennee@linaro.org>

diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index 3e34b07c98..c9237950d0 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -1,3 +1,5 @@
+.. _qom:
+
 ===========================
 The QEMU Object Model (QOM)
 ===========================
diff --git a/docs/devel/style.rst b/docs/devel/style.rst
index 5bc6f2f095..ac2ce42a2f 100644
--- a/docs/devel/style.rst
+++ b/docs/devel/style.rst
@@ -628,6 +628,43 @@ are still some caveats to beware of
 QEMU Specific Idioms
 ********************
 
+QEMU Object Model Declarations
+==============================
+
+The QEMU Object Model (QOM) provides a framework for handling objects
+in the base C language. The first declaration of a storage or class
+structure should always be the parent and leave a visual space between
+that declaration and the new code. It is also useful to separate
+backing for properties (options driven by the user) and internal state
+to make navigation easier.
+
+For a storage structure the first declaration should always be called
+"parent_obj" and for a class structure the first member should always
+be called "parent_class" as below:
+
+.. code-block:: c
+
+    struct MyDeviceState {
+        DeviceState parent_obj;
+
+        /* Properties */
+        int prop_a;
+        char *prop_b;
+        /* Other stuff */
+        int internal_state;
+    };
+
+    struct MyDeviceClass {
+        DeviceClass parent_class;
+
+        void (*new_fn1)(void);
+        bool (*new_fn2)(CPUState *);
+    };
+
+Note that there is no need to provide typedefs for QOM structures
+since these are generated automatically by the QOM declaration macros.
+See :ref:`qom` for more details.
+
 Error handling and reporting
 ============================
 
-- 
2.39.2



  parent reply	other threads:[~2023-04-27 15:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 15:44 [PULL 00/18] testing and doc updates Alex Bennée
2023-04-27 15:44 ` [PULL 01/18] tests/requirements.txt: bump up avocado-framework version to 101.0 Alex Bennée
2023-04-27 15:44 ` [PULL 02/18] tests/avocado: use the new snapshots for testing Alex Bennée
2023-04-28 12:08   ` Thomas Huth
2023-04-28 16:43     ` Alex Bennée
2023-04-27 15:44 ` [PULL 03/18] tests/avocado: Add set of boot tests on SBSA-ref Alex Bennée
2023-04-28 10:33   ` Thomas Huth
2023-07-10 12:10     ` Thomas Huth
2023-04-27 15:44 ` [PULL 04/18] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs Alex Bennée
2023-04-27 15:44 ` [PULL 05/18] scripts/device-crash-test: Add a parameter to run with TCG only Alex Bennée
2023-04-27 15:44 ` [PULL 06/18] qemu-options: finesse the recommendations around -blockdev Alex Bennée
2023-04-27 15:44 ` [PULL 07/18] .gitlab-ci.d/cirrus: Drop the CI job for compiling with FreeBSD 12 Alex Bennée
2023-04-27 15:45 ` [PULL 08/18] tests/avocado: Make ssh_command_output_contains() globally available Alex Bennée
2023-04-27 15:45 ` [PULL 09/18] tests/avocado/machine_aspeed: Fix the broken ast2[56]00_evb_sdk tests Alex Bennée
2023-04-27 15:45 ` [PULL 10/18] MAINTAINERS: Cover tests/avocado/machine_aspeed.py Alex Bennée
2023-04-27 15:45 ` [PULL 11/18] avocado_qemu/__init__.py: factor out the qemu-img finding Alex Bennée
2023-04-27 15:45 ` [PULL 12/18] tests/avocado/tuxrun_baselines.py: improve code coverage for ppc64 Alex Bennée
2023-04-27 15:45 ` [PULL 13/18] tests/tcg: limit the scope of the plugin tests Alex Bennée
2023-04-27 15:45 ` [PULL 14/18] qemu-options.hx: Update descriptions of memory options for NUMA node Alex Bennée
2023-04-27 15:45 ` [PULL 15/18] docs/system: remove excessive punctuation from guest-loader docs Alex Bennée
2023-04-27 15:45 ` [PULL 16/18] docs/devel: make a statement about includes Alex Bennée
2023-04-27 15:45 ` Alex Bennée [this message]
2023-04-27 15:45 ` [PULL 18/18] docs/style: call out the use of GUARD macros Alex Bennée
2023-04-28  7:34 ` [PULL 00/18] testing and doc updates Richard Henderson
2023-05-02 11:46 ` Peter Maydell
2023-05-02 12:21   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427154510.1791273-18-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).