From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, Juan Quintela <quintela@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: [PULL 17/17] docs/devel/qapi-code-gen: Describe some doc markup pitfalls
Date: Fri, 28 Apr 2023 12:29:01 +0200 [thread overview]
Message-ID: <20230428102901.1685375-18-armbru@redhat.com> (raw)
In-Reply-To: <20230428102901.1685375-1-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230427095346.1238913-1-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
docs/devel/qapi-code-gen.rst | 53 ++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index ea0592034a..af1986f33e 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -1060,6 +1060,59 @@ For example::
'returns': ['BlockStats'] }
+Markup pitfalls
+~~~~~~~~~~~~~~~
+
+A blank line is required between list items and paragraphs. Without
+it, the list may not be recognized, resulting in garbled output. Good
+example::
+
+ # An event's state is modified if:
+ #
+ # - its name matches the @name pattern, and
+ # - if @vcpu is given, the event has the "vcpu" property.
+
+Without the blank line this would be a single paragraph.
+
+Indentation matters. Bad example::
+
+ # @none: None (no memory side cache in this proximity domain,
+ # or cache associativity unknown)
+
+The description is parsed as a definition list with term "None (no
+memory side cache in this proximity domain," and definition "or cache
+associativity unknown)".
+
+Section tags are case-sensitive and end with a colon. Good example::
+
+ # Since: 7.1
+
+Bad examples (all ordinary paragraphs)::
+
+ # since: 7.1
+
+ # Since 7.1
+
+ # Since : 7.1
+
+Likewise, member descriptions require a colon. Good example::
+
+ # @interface-id: Interface ID
+
+Bad examples (all ordinary paragraphs)::
+
+ # @interface-id Interface ID
+
+ # @interface-id : Interface ID
+
+Undocumented members are not flagged, yet. Instead, the generated
+documentation describes them as "Not documented". Think twice before
+adding more undocumented members.
+
+When you change documentation comments, please check the generated
+documentation comes out as intended!
+
+
Client JSON Protocol introspection
==================================
--
2.39.2
next prev parent reply other threads:[~2023-04-28 10:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:28 [PULL 00/17] QAPI patches patches for 2023-04-28 Markus Armbruster
2023-04-28 10:28 ` [PULL 01/17] qga/qapi-schema: Tidy up documentation of guest-fsfreeze-status Markus Armbruster
2023-04-28 10:28 ` [PULL 02/17] qga/qapi-schema: Fix a misspelled reference Markus Armbruster
2023-04-28 10:28 ` [PULL 03/17] qapi: Fix misspelled references Markus Armbruster
2023-04-28 10:28 ` [PULL 04/17] qapi: Fix up references to long gone error classes Markus Armbruster
2023-04-28 10:28 ` [PULL 05/17] qapi/block-core: Clean up after removal of dirty bitmap @status Markus Armbruster
2023-04-28 10:28 ` [PULL 06/17] qapi: @foo should be used to reference, not ``foo`` Markus Armbruster
2023-04-28 10:28 ` [PULL 07/17] qapi: Tidy up examples Markus Armbruster
2023-04-28 10:28 ` [PULL 08/17] qapi: Delete largely misleading "Stability Considerations" Markus Armbruster
2023-04-28 10:28 ` [PULL 09/17] qapi: Fix bullet list markup in documentation Markus Armbruster
2023-04-28 10:28 ` [PULL 10/17] qapi: Fix unintended definition lists " Markus Armbruster
2023-04-28 10:28 ` [PULL 11/17] qga/qapi-schema: Fix member documentation markup Markus Armbruster
2023-04-28 10:28 ` [PULL 12/17] qapi: Fix argument " Markus Armbruster
2023-04-28 10:28 ` [PULL 13/17] qapi: Replace ad hoc "since" documentation by member documentation Markus Armbruster
2023-04-28 10:28 ` [PULL 14/17] qapi: Fix misspelled section tags in doc comments Markus Armbruster
2023-04-28 10:28 ` [PULL 15/17] qapi: Format since information the conventional way: (since X.Y) Markus Armbruster
2023-04-28 10:29 ` [PULL 16/17] qapi storage-daemon/qapi: Fix documentation section structure Markus Armbruster
2023-04-28 10:29 ` Markus Armbruster [this message]
2023-04-29 9:04 ` [PULL 00/17] QAPI patches patches for 2023-04-28 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428102901.1685375-18-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).