qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
	Leonardo Bras <leobras@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: [PATCH 1/5] migration: Make RAM_SAVE_FLAG_HOOK a normal case entry
Date: Thu,  4 May 2023 13:44:39 +0200	[thread overview]
Message-ID: <20230504114443.23891-2-quintela@redhat.com> (raw)
In-Reply-To: <20230504114443.23891-1-quintela@redhat.com>

Fixes this commit, clearly a bad merge after a rebase or similar, it
should have been its own case since that point.

commit 5b0e9dd46fbda5152566a4a26fd96bc0d0452bf7
Author: Peter Lieven <pl@kamp.de>
Date:   Tue Jun 24 11:32:36 2014 +0200

    migration: catch unknown flag combinations in ram_load

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/ram.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 7d81c4a39e..43338e1f5b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4445,14 +4445,12 @@ static int ram_load_precopy(QEMUFile *f)
                 multifd_recv_sync_main();
             }
             break;
+        case RAM_SAVE_FLAG_HOOK:
+            ram_control_load_hook(f, RAM_CONTROL_HOOK, NULL);
+            break;
         default:
-            if (flags & RAM_SAVE_FLAG_HOOK) {
-                ram_control_load_hook(f, RAM_CONTROL_HOOK, NULL);
-            } else {
-                error_report("Unknown combination of migration flags: 0x%x",
-                             flags);
-                ret = -EINVAL;
-            }
+            error_report("Unknown combination of migration flags: 0x%x", flags);
+            ret = -EINVAL;
         }
         if (!ret) {
             ret = qemu_file_get_error(f);
-- 
2.40.0



  reply	other threads:[~2023-05-04 11:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 11:44 [PATCH 0/5] Migration RDMA cleanup Juan Quintela
2023-05-04 11:44 ` Juan Quintela [this message]
2023-05-04 17:03   ` [PATCH 1/5] migration: Make RAM_SAVE_FLAG_HOOK a normal case entry Daniel P. Berrangé
2023-05-26 21:09   ` Peter Xu
2023-05-04 11:44 ` [PATCH 2/5] migration/rdma: simplify ram_control_load_hook() Juan Quintela
2023-05-04 17:03   ` Daniel P. Berrangé
2023-05-26 21:10   ` Peter Xu
2023-05-04 11:44 ` [PATCH 3/5] migration/rdma: We can calculate the rioc from the QEMUFile Juan Quintela
2023-05-04 17:04   ` Daniel P. Berrangé
2023-05-26 21:10   ` Peter Xu
2023-05-04 11:44 ` [PATCH 4/5] migration/rdma: It makes no sense to recive that flag without RDMA Juan Quintela
2023-05-04 17:05   ` Daniel P. Berrangé
2023-05-04 22:53     ` Juan Quintela
2023-05-26 21:15   ` Peter Xu
2023-05-04 11:44 ` [PATCH 5/5] migration/rdma: Check for postcopy sooner Juan Quintela
2023-05-04 17:05   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230504114443.23891-2-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).