* [PATCH] hw: Fix format for comments
@ 2023-05-05 7:23 Shaoqin Huang
0 siblings, 0 replies; 3+ messages in thread
From: Shaoqin Huang @ 2023-05-05 7:23 UTC (permalink / raw)
To: qemu-devel
Cc: Shaoqin Huang, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Since
we are at here, resort the parameters in comments to match the sequence
of parameters which defined in the CPUArchId.
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
include/hw/boards.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index f4117fdb9a..cefa3d5897 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
/**
* CPUArchId:
* @arch_id - architecture-dependent CPU ID of present or possible CPU
+ * @vcpus_count - number of threads provided by @cpu object
+ * @props - CPU object properties, initialized by board
* @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
* @type - QOM class name of possible @cpu object
- * @props - CPU object properties, initialized by board
- * #vcpus_count - number of threads provided by @cpu object
*/
typedef struct CPUArchId {
uint64_t arch_id;
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] hw: Fix format for comments
@ 2023-05-15 7:25 Shaoqin Huang
2023-06-06 13:29 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Shaoqin Huang @ 2023-05-15 7:25 UTC (permalink / raw)
To: qemu-devel
Cc: Shaoqin Huang, Igor Mammedov, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Since
we are at here, resort the parameters in comments to match the sequence
of parameters which defined in the CPUArchId.
CC: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
include/hw/boards.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index f4117fdb9a..cefa3d5897 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
/**
* CPUArchId:
* @arch_id - architecture-dependent CPU ID of present or possible CPU
+ * @vcpus_count - number of threads provided by @cpu object
+ * @props - CPU object properties, initialized by board
* @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
* @type - QOM class name of possible @cpu object
- * @props - CPU object properties, initialized by board
- * #vcpus_count - number of threads provided by @cpu object
*/
typedef struct CPUArchId {
uint64_t arch_id;
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw: Fix format for comments
2023-05-15 7:25 Shaoqin Huang
@ 2023-06-06 13:29 ` Igor Mammedov
0 siblings, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2023-06-06 13:29 UTC (permalink / raw)
To: Shaoqin Huang
Cc: qemu-devel, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
On Mon, 15 May 2023 03:25:25 -0400
Shaoqin Huang <shahuang@redhat.com> wrote:
> Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments.
> Since
> we are at here, resort the parameters in comments to match the sequence
While at it, reorder ...
> of parameters which defined in the CPUArchId.
>
> CC: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
with commit message fixed up
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> include/hw/boards.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index f4117fdb9a..cefa3d5897 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
> /**
> * CPUArchId:
> * @arch_id - architecture-dependent CPU ID of present or possible CPU
> + * @vcpus_count - number of threads provided by @cpu object
> + * @props - CPU object properties, initialized by board
> * @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
> * @type - QOM class name of possible @cpu object
> - * @props - CPU object properties, initialized by board
> - * #vcpus_count - number of threads provided by @cpu object
> */
> typedef struct CPUArchId {
> uint64_t arch_id;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-06 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 7:23 [PATCH] hw: Fix format for comments Shaoqin Huang
-- strict thread matches above, loose matches on Subject: below --
2023-05-15 7:25 Shaoqin Huang
2023-06-06 13:29 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).