qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sbsa-ref: use Bochs graphics card instead of VGA
@ 2023-05-05 12:09 Marcin Juszkiewicz
  2023-05-17 10:55 ` Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Marcin Juszkiewicz @ 2023-05-05 12:09 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-arm, Leif Lindholm, Peter Maydell, Marcin Juszkiewicz

Bochs card is normal PCI Express card so it fits better in system with
PCI Express bus. VGA is simple legacy PCI card.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 hw/arm/sbsa-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 3e3671f66e..0ace0fcc35 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -679,7 +679,7 @@ static void create_pcie(SBSAMachineState *sms)
         }
     }
 
-    pci_create_simple(pci->bus, -1, "VGA");
+    pci_create_simple(pci->bus, -1, "bochs-display");
 
     create_smmu(sms, pci->bus);
 }
-- 
2.40.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sbsa-ref: use Bochs graphics card instead of VGA
  2023-05-05 12:09 [PATCH] sbsa-ref: use Bochs graphics card instead of VGA Marcin Juszkiewicz
@ 2023-05-17 10:55 ` Leif Lindholm
  2023-05-18 10:14   ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2023-05-17 10:55 UTC (permalink / raw)
  To: Marcin Juszkiewicz, qemu-devel; +Cc: qemu-arm, Peter Maydell

On 2023-05-05 13:09, Marcin Juszkiewicz wrote:
> Bochs card is normal PCI Express card so it fits better in system with
> PCI Express bus. VGA is simple legacy PCI card.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

> ---
>   hw/arm/sbsa-ref.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 3e3671f66e..0ace0fcc35 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -679,7 +679,7 @@ static void create_pcie(SBSAMachineState *sms)
>           }
>       }
>   
> -    pci_create_simple(pci->bus, -1, "VGA");
> +    pci_create_simple(pci->bus, -1, "bochs-display");
>   
>       create_smmu(sms, pci->bus);
>   }



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sbsa-ref: use Bochs graphics card instead of VGA
  2023-05-17 10:55 ` Leif Lindholm
@ 2023-05-18 10:14   ` Peter Maydell
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-05-18 10:14 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: Marcin Juszkiewicz, qemu-devel, qemu-arm

On Wed, 17 May 2023 at 11:55, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On 2023-05-05 13:09, Marcin Juszkiewicz wrote:
> > Bochs card is normal PCI Express card so it fits better in system with
> > PCI Express bus. VGA is simple legacy PCI card.
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>



Applied to target-arm.next, thanks.

-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-18 10:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 12:09 [PATCH] sbsa-ref: use Bochs graphics card instead of VGA Marcin Juszkiewicz
2023-05-17 10:55 ` Leif Lindholm
2023-05-18 10:14   ` Peter Maydell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).