From: "Alex Bennée" <alex.bennee@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Michael Roth" <michael.roth@amd.com>,
"Eric Blake" <eblake@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Kyle Evans" <kevans@freebsd.org>, "Warner Losh" <imp@bsdimp.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v3 00/10] tracing: remove dynamic vcpu state
Date: Fri, 5 May 2023 16:53:26 +0100 [thread overview]
Message-ID: <20230505155336.137393-1-alex.bennee@linaro.org> (raw)
Hi Stefan,
The references dynamic vcpu tracing support was removed when the
original TCG trace points where removed. However there was still a
legacy of dynamic trace state to track this in cpu.h and extra hash
variables to track TBs. While the removed vcpu tracepoints are not in
generated code (or helpers) they still bring in a bunch of machinery
to manage the state so I've pulled them out. We keep and rename one
(cpu_reset) to a static trace points which dump vcpu->index as it is
useful to f4bug.
v3 fixes some minor comments and instead of simplifying to
qemu_xxhash6 we extend to qemu_xxhash8 so we can include cs_base. I've
added some initial benchmarks to the comments but you might want to
drop the last patch and leave it up to Richard to queue via his tree
once you've merged.
Please queue into your tree.
Alex Bennée (10):
*-user: remove the guest_user_syscall tracepoints
trace-events: remove the remaining vcpu trace events
trace: remove vcpu_id from the TraceEvent structure
scripts/qapi: document the tool that generated the file
qapi: make the vcpu parameters deprecated for 8.1
trace: remove code that depends on setting vcpu
trace: remove control-vcpu.h
tcg: remove the final vestiges of dstate
hw/9pfs: use qemu_xxhash4
accel/tcg: include cs_base in our hash calculations
qapi/trace.json | 22 +++----
accel/tcg/tb-hash.h | 7 ++-
include/exec/exec-all.h | 3 -
include/hw/core/cpu.h | 5 --
include/qemu/xxhash.h | 21 +++++--
include/user/syscall-trace.h | 4 --
trace/control-internal.h | 10 ---
trace/control-vcpu.h | 63 -------------------
trace/control.h | 48 ---------------
trace/event-internal.h | 2 -
accel/tcg/cpu-exec.c | 7 +--
accel/tcg/tb-maint.c | 5 +-
accel/tcg/translate-all.c | 6 --
bsd-user/freebsd/os-syscall.c | 2 -
hw/9pfs/9p.c | 5 +-
hw/core/cpu-common.c | 6 +-
stubs/trace-control.c | 13 ----
trace/control-target.c | 111 +++-------------------------------
trace/control.c | 28 ---------
trace/qmp.c | 76 +++--------------------
trace/trace-hmp-cmds.c | 17 +-----
hw/core/trace-events | 3 +
scripts/qapi/gen.py | 4 +-
scripts/tracetool/format/c.py | 6 --
scripts/tracetool/format/h.py | 16 +----
trace-events | 50 ---------------
26 files changed, 60 insertions(+), 480 deletions(-)
delete mode 100644 trace/control-vcpu.h
--
2.39.2
next reply other threads:[~2023-05-05 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 15:53 Alex Bennée [this message]
2023-05-05 15:53 ` [PATCH v3 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-05-05 15:53 ` [PATCH v3 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-05-05 15:53 ` [PATCH v3 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-05-05 15:53 ` [PATCH v3 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-05-06 7:34 ` Markus Armbruster
2023-05-05 15:53 ` [PATCH v3 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-05-06 7:20 ` Markus Armbruster
2023-05-05 15:53 ` [PATCH v3 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-05-10 7:46 ` Philippe Mathieu-Daudé
2023-05-23 12:11 ` Alex Bennée
2023-05-05 15:53 ` [PATCH v3 07/10] trace: remove control-vcpu.h Alex Bennée
2023-05-05 15:53 ` [PATCH v3 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-05-10 7:48 ` Philippe Mathieu-Daudé
2023-05-05 15:53 ` [PATCH v3 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-05-05 15:53 ` [PATCH v3 10/10] accel/tcg: include cs_base in our hash calculations Alex Bennée
2023-05-05 18:27 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505155336.137393-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).