[PATCH] docs/devel: remind developers to run CI container pipeline when updating images

[PATCH] docs/devel: remind developers to run CI container pipeline when updating images

[Ani Sinha]

When new dependencies and packages are added to containers, its important to
run CI container generation pipelines on gitlab to make sure that there are no
obvious conflicts between packages that are being added and those that are
already present. Running CI container pipelines will make sure that there are
no such breakages before we commit the change updating the containers. Add a
line in the documentation reminding developers to run the pipeline before
submitting the change. It will also ease the life of the maintainers.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 docs/devel/testing.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 4071e72710..203facb417 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -479,6 +479,12 @@ first to contribute the mapping to the ``libvirt-ci`` project:
    contains the ``mappings.yml`` update.  Then add the prerequisite and
    run ``make lcitool-refresh``.
 
+ * Please also trigger gitlab container generation pipelines on your change
+   for as many OS distros as practical to make sure that there are no
+   obvious breakages when adding the new pre-requisite. Please see
+   `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
+   page on how to trigger gitlab CI pipelines on your change.
+
 For enterprise distros that default to old, end-of-life versions of the
 Python runtime, QEMU uses a separate set of mappings that work with more
 recent versions.  These can be found in ``tests/lcitool/mappings.yml``.
-- 
2.31.1

Re: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images

[Daniel P. Berrangé]

On Sat, May 06, 2023 at 12:50:12PM +0530, Ani Sinha wrote:
> When new dependencies and packages are added to containers, its important to
> run CI container generation pipelines on gitlab to make sure that there are no
> obvious conflicts between packages that are being added and those that are
> already present. Running CI container pipelines will make sure that there are
> no such breakages before we commit the change updating the containers. Add a
> line in the documentation reminding developers to run the pipeline before
> submitting the change. It will also ease the life of the maintainers.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>  docs/devel/testing.rst | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images

[Alex Bennée]

Ani Sinha <anisinha@redhat.com> writes:

> When new dependencies and packages are added to containers, its important to
> run CI container generation pipelines on gitlab to make sure that there are no
> obvious conflicts between packages that are being added and those that are
> already present. Running CI container pipelines will make sure that there are
> no such breakages before we commit the change updating the containers. Add a
> line in the documentation reminding developers to run the pipeline before
> submitting the change. It will also ease the life of the maintainers.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images

[Ani Sinha]

> On 18-May-2023, at 6:34 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
> 
> 
> Ani Sinha <anisinha@redhat.com> writes:
> 
>> When new dependencies and packages are added to containers, its important to
>> run CI container generation pipelines on gitlab to make sure that there are no
>> obvious conflicts between packages that are being added and those that are
>> already present. Running CI container pipelines will make sure that there are
>> no such breakages before we commit the change updating the containers. Add a
>> line in the documentation reminding developers to run the pipeline before
>> submitting the change. It will also ease the life of the maintainers.
>> 
>> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> 
> Queued to testing/next, thanks.

Alex, Thomas already merged this, see 2a851fca9fcf6