From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Mads Ynddal <mads@ynddal.dk>, qemu-devel <qemu-devel@nongnu.org>,
Cleber Rosa <crosa@redhat.com>,
Mads Ynddal <m.ynddal@samsung.com>
Subject: Re: [PATCH v2 00/12] simpletrace: refactor and general improvements
Date: Mon, 8 May 2023 11:07:40 -0400 [thread overview]
Message-ID: <20230508150740.GC581920@fedora> (raw)
In-Reply-To: <CAFn=p-ZhsUgMrK+w+ibP68q-v093SDEfhqxHsfTtFfS3qxD9ow@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Thu, May 04, 2023 at 01:53:38PM -0400, John Snow wrote:
> On Thu, May 4, 2023, 1:48 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> > On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote:
> > > From: Mads Ynddal <m.ynddal@samsung.com>
> > >
> > > I wanted to use simpletrace.py for an internal project, so I tried to
> > update
> > > and polish the code. Some of the commits resolve specific issues, while
> > some
> > > are more subjective.
> >
> > An internal project based on qemu.git or a completely separate codebase?
> >
> > Sometimes I've wondered whether tracetool should be extracted from
> > qemu.git and moved into its own QEMU-independent place. That way other
> > C/C++ applications and libraries could use it easily.
> >
> > Now that Alex Bennee removed the vcpu trace events that were specific to
> > QEMU, the tracing code is less tightly coupled to QEMU. There are
> > probably still a number of places that need to be cleaned up in order
> > for the tracing code to be independent of QEMU though.
> >
> > If there is interest in doing this, I support the effort, although I'm
> > not sure how much time I have to actually do the work myself.
> >
>
> I meant internal, but if there's interest in fully extracting it, I have a
> playbook for that now based on my efforts to do the same for qemu.qmp and I
> can offer good stewardship for that process.
I was curious how Mads is using simpletrace for an internal (to
Samsung?) project.
Maybe only simpletrace.py is needed because Mads' own code emits trace
logs in the simpletrace binary format, but in the general case we could
extract most of QEMU's tracing infrastructure (including tracetool).
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-08 15:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 9:23 [PATCH v2 00/12] simpletrace: refactor and general improvements Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 01/12] simpletrace: Improve parsing of sys.argv; fix files never closed Mads Ynddal
2023-05-04 18:03 ` Stefan Hajnoczi
2023-05-08 13:18 ` Mads Ynddal
2023-05-08 15:08 ` Stefan Hajnoczi
2023-05-02 9:23 ` [PATCH v2 02/12] simpletrace: Annotate magic constants from QEMU code Mads Ynddal
2023-05-09 14:34 ` Stefan Hajnoczi
2023-05-15 6:51 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 03/12] simpletrace: changed naming of edict and idtoname to improve readability Mads Ynddal
2023-05-09 14:36 ` Stefan Hajnoczi
2023-05-02 9:23 ` [PATCH v2 04/12] simpletrace: update code for Python 3.11 Mads Ynddal
2023-05-09 14:38 ` Stefan Hajnoczi
2023-05-15 6:47 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 05/12] simpletrace: Changed Analyzer class to become context-manager Mads Ynddal
2023-05-09 14:40 ` Stefan Hajnoczi
2023-05-15 7:48 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 06/12] simpletrace: Simplify construction of tracing methods Mads Ynddal
2023-05-09 14:40 ` Stefan Hajnoczi
2023-05-15 8:11 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 07/12] simpletrace: Improved error handling on struct unpack Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 08/12] simpletrace: define exception and add handling Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 09/12] simpletrace: Refactor to separate responsibilities Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 10/12] MAINTAINERS: add maintainer of simpletrace.py Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 11/12] scripts/analyse-locks-simpletrace.py: changed iteritems() to items() Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 12/12] scripts/analyse-locks-simpletrace.py: reflect changes to process in simpletrace.py Mads Ynddal
2023-05-03 13:55 ` [PATCH v2 00/12] simpletrace: refactor and general improvements John Snow
2023-05-08 13:28 ` Mads Ynddal
2023-05-08 15:16 ` Stefan Hajnoczi
2023-05-10 19:14 ` John Snow
2023-05-04 17:48 ` Stefan Hajnoczi
2023-05-04 17:53 ` John Snow
2023-05-08 15:07 ` Stefan Hajnoczi [this message]
2023-05-08 16:50 ` Mads Ynddal
2023-05-09 14:33 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508150740.GC581920@fedora \
--to=stefanha@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=m.ynddal@samsung.com \
--cc=mads@ynddal.dk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).