qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 02/16] test-aio-multithread: do not use mb_read/mb_set for simple flags
Date: Tue,  9 May 2023 11:04:39 +0200	[thread overview]
Message-ID: <20230509090453.37884-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20230509090453.37884-1-pbonzini@redhat.com>

The remaining use of mb_read/mb_set is just to force a thread to exit
eventually.  It does not order two memory accesses and therefore can be
just read/set.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/unit/test-aio-multithread.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/unit/test-aio-multithread.c b/tests/unit/test-aio-multithread.c
index a555cc883505..3c61526a0b46 100644
--- a/tests/unit/test-aio-multithread.c
+++ b/tests/unit/test-aio-multithread.c
@@ -202,7 +202,7 @@ static CoMutex comutex;
 
 static void coroutine_fn test_multi_co_mutex_entry(void *opaque)
 {
-    while (!qatomic_mb_read(&now_stopping)) {
+    while (!qatomic_read(&now_stopping)) {
         qemu_co_mutex_lock(&comutex);
         counter++;
         qemu_co_mutex_unlock(&comutex);
@@ -236,7 +236,7 @@ static void test_multi_co_mutex(int threads, int seconds)
 
     g_usleep(seconds * 1000000);
 
-    qatomic_mb_set(&now_stopping, true);
+    qatomic_set(&now_stopping, true);
     while (running > 0) {
         g_usleep(100000);
     }
@@ -327,7 +327,7 @@ static void mcs_mutex_unlock(void)
 
 static void test_multi_fair_mutex_entry(void *opaque)
 {
-    while (!qatomic_mb_read(&now_stopping)) {
+    while (!qatomic_read(&now_stopping)) {
         mcs_mutex_lock();
         counter++;
         mcs_mutex_unlock();
@@ -355,7 +355,7 @@ static void test_multi_fair_mutex(int threads, int seconds)
 
     g_usleep(seconds * 1000000);
 
-    qatomic_mb_set(&now_stopping, true);
+    qatomic_set(&now_stopping, true);
     while (running > 0) {
         g_usleep(100000);
     }
@@ -383,7 +383,7 @@ static QemuMutex mutex;
 
 static void test_multi_mutex_entry(void *opaque)
 {
-    while (!qatomic_mb_read(&now_stopping)) {
+    while (!qatomic_read(&now_stopping)) {
         qemu_mutex_lock(&mutex);
         counter++;
         qemu_mutex_unlock(&mutex);
@@ -411,7 +411,7 @@ static void test_multi_mutex(int threads, int seconds)
 
     g_usleep(seconds * 1000000);
 
-    qatomic_mb_set(&now_stopping, true);
+    qatomic_set(&now_stopping, true);
     while (running > 0) {
         g_usleep(100000);
     }
-- 
2.40.1



  parent reply	other threads:[~2023-05-09  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  9:04 [PULL 00/16] Misc patches for 2023-05-09 Paolo Bonzini
2023-05-09  9:04 ` [PULL 01/16] rcu: remove qatomic_mb_set, expand comments Paolo Bonzini
2023-05-09  9:04 ` Paolo Bonzini [this message]
2023-05-09  9:04 ` [PULL 03/16] test-aio-multithread: simplify test_multi_co_schedule Paolo Bonzini
2023-05-09  9:04 ` [PULL 04/16] call_rcu: stop using mb_set/mb_read Paolo Bonzini
2023-05-09  9:04 ` [PULL 05/16] tb-maint: do not use mb_read/mb_set Paolo Bonzini
2023-05-09  9:04 ` [PULL 06/16] MAINTAINERS: add stanza for Kconfig files Paolo Bonzini
2023-05-09  9:04 ` [PULL 07/16] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API Paolo Bonzini
2023-05-09  9:04 ` [PULL 08/16] target/i386: allow versioned CPUs to specify new cache_info Paolo Bonzini
2023-05-09  9:04 ` [PULL 09/16] target/i386: Add new EPYC CPU versions with updated cache_info Paolo Bonzini
2023-05-09  9:04 ` [PULL 10/16] target/i386: Add a couple of feature bits in 8000_0008_EBX Paolo Bonzini
2023-05-09  9:04 ` [PULL 11/16] target/i386: Add feature bits for CPUID_Fn80000021_EAX Paolo Bonzini
2023-05-09  9:04 ` [PULL 12/16] target/i386: Add missing feature bits in EPYC-Milan model Paolo Bonzini
2023-05-09  9:04 ` [PULL 13/16] target/i386: Add VNMI and automatic IBRS feature bits Paolo Bonzini
2023-05-09  9:04 ` [PULL 14/16] target/i386: Add EPYC-Genoa model to support Zen 4 processor series Paolo Bonzini
2023-05-09  9:04 ` [PULL 15/16] docs: clarify --without-default-devices Paolo Bonzini
2023-05-09  9:04 ` [PULL 16/16] meson: leave unnecessary modules out of the build Paolo Bonzini
2023-05-10  5:12 ` [PULL 00/16] Misc patches for 2023-05-09 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509090453.37884-3-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).