qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Leonardo Bras <leobras@redhat.com>,
	Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: [PATCH v3 00/10] migration: Remove QEMUFileHooks
Date: Tue,  9 May 2023 14:06:50 +0200	[thread overview]
Message-ID: <20230509120700.78359-1-quintela@redhat.com> (raw)

Hi

Changes in v3:
- fix rdma_migration to reset clearly (thanks danp)
- redo the cherks for migration/rdma
- rebased on top of the counters series:
[PATCH 00/21] Migration: More migration atomic counters
Based-on: Message-Id: <20230508130909.65420-1-quintela@redhat.com>

Please, review.

Changes in v2:
- rebased on top of migration-20230428 pull (second try)
- several of the patches on the PULL request
- make clean that we don't use rdma code when we don't use rdma
- create migrate_rdma() to check if we are in rdma migration.

There is no hope for this code. I am trying to cleanup the rest of
rdma calls, but the code is convoluted as hell.  And it lies with the
ram counters as crazy.

Please review.

In this series (v1):
- QEMUFileHooks only had a single user, RDMA migration.  Just remove the
  hooks and create stubs for when RDMA is not compiled in.

- This implies that we have to move all the operations from
  migration/qemu-file.c to migration/rdma.c.

- I now we can still simplify rdma_control_save_page(), but I don't
  have an easy setup for testing.

- Yes, the goal of the whole operations is to be able to move
  ram_file_limit from qemu-file to migration.c.

Please review.

Thanks, Juan.

Juan Quintela (10):
  migration: Create migrate_rdma()
  migration/rdma: Unfold ram_control_before_iterate()
  migration/rdma: Unfold ram_control_after_iterate()
  migration/rdma: Remove all uses of RAM_CONTROL_HOOK
  migration/rdma: Unfold hook_ram_load()
  migration/rdma: Create rdma_control_save_page()
  qemu-file: Remove QEMUFileHooks
  migration/rdma: Move rdma constants from qemu-file.h to rdma.h
  migration/rdma: Remove qemu_ prefix from exported functions
  migration/rdma: Check sooner if we are in postcopy for save_page()

 migration/migration.c  |   1 +
 migration/migration.h  |   3 +
 migration/options.c    |   7 +++
 migration/options.h    |   1 +
 migration/qemu-file.c  |  61 +--------------------
 migration/qemu-file.h  |  49 -----------------
 migration/ram.c        |  50 +++++++++++++----
 migration/rdma.c       | 121 +++++++++++++++++++----------------------
 migration/rdma.h       |  34 ++++++++++++
 migration/trace-events |  28 +++++-----
 10 files changed, 155 insertions(+), 200 deletions(-)

-- 
2.40.0



             reply	other threads:[~2023-05-09 12:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 12:06 Juan Quintela [this message]
2023-05-09 12:06 ` [PATCH v3 01/10] migration: Create migrate_rdma() Juan Quintela
2023-05-09 12:06 ` [PATCH v3 02/10] migration/rdma: Unfold ram_control_before_iterate() Juan Quintela
2023-05-09 12:06 ` [PATCH v3 03/10] migration/rdma: Unfold ram_control_after_iterate() Juan Quintela
2023-05-09 12:06 ` [PATCH v3 04/10] migration/rdma: Remove all uses of RAM_CONTROL_HOOK Juan Quintela
2023-05-09 12:06 ` [PATCH v3 05/10] migration/rdma: Unfold hook_ram_load() Juan Quintela
2023-05-09 12:06 ` [PATCH v3 06/10] migration/rdma: Create rdma_control_save_page() Juan Quintela
2023-05-09 12:06 ` [PATCH v3 07/10] qemu-file: Remove QEMUFileHooks Juan Quintela
2023-05-09 12:06 ` [PATCH v3 08/10] migration/rdma: Move rdma constants from qemu-file.h to rdma.h Juan Quintela
2023-05-09 12:06 ` [PATCH v3 09/10] migration/rdma: Remove qemu_ prefix from exported functions Juan Quintela
2023-05-09 12:07 ` [PATCH v3 10/10] migration/rdma: Check sooner if we are in postcopy for save_page() Juan Quintela
2023-05-26 21:41 ` [PATCH v3 00/10] migration: Remove QEMUFileHooks Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509120700.78359-1-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).