* [PATCH] Fix QEMU crash caused when NUMA nodes exceed available CPUs
@ 2023-05-09 6:44 Yin Wang
2023-05-09 12:12 ` Igor Mammedov
0 siblings, 1 reply; 2+ messages in thread
From: Yin Wang @ 2023-05-09 6:44 UTC (permalink / raw)
To: qemu-devel
Cc: Yin Wang, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
command "qemu-system-riscv64 -machine virt
-m 2G -smp 1 -numa node,mem=1G -numa node,mem=1G"
would trigger this problem.
This commit fixes the issue by adding parameter checks.
Signed-off-by: Yin Wang <yin.wang@intel.com>
---
hw/core/numa.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index d8d36b16d8..ff249369be 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -168,6 +168,13 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node,
numa_info[nodenr].present = true;
max_numa_nodeid = MAX(max_numa_nodeid, nodenr + 1);
ms->numa_state->num_nodes++;
+ if (ms->smp.max_cpus < ms->numa_state->num_nodes) {
+ error_setg(errp,
+ "Number of NUMA nodes:(%d)"
+ " is larger than number of CPUs:(%d)",
+ ms->numa_state->num_nodes, ms->smp.max_cpus);
+ return;
+ }
}
static
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix QEMU crash caused when NUMA nodes exceed available CPUs
2023-05-09 6:44 [PATCH] Fix QEMU crash caused when NUMA nodes exceed available CPUs Yin Wang
@ 2023-05-09 12:12 ` Igor Mammedov
0 siblings, 0 replies; 2+ messages in thread
From: Igor Mammedov @ 2023-05-09 12:12 UTC (permalink / raw)
To: Yin Wang
Cc: qemu-devel, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
On Tue, 9 May 2023 14:44:52 +0800
Yin Wang <yin.wang@intel.com> wrote:
> command "qemu-system-riscv64 -machine virt
> -m 2G -smp 1 -numa node,mem=1G -numa node,mem=1G"
> would trigger this problem.
> This commit fixes the issue by adding parameter checks.
It seems wrong to apply this to all targets (that
potentially excludes CPU-less nodes in some cases).
PS:
Crash backtrace should be mentioned in commit message.
>
> Signed-off-by: Yin Wang <yin.wang@intel.com>
> ---
> hw/core/numa.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/core/numa.c b/hw/core/numa.c
> index d8d36b16d8..ff249369be 100644
> --- a/hw/core/numa.c
> +++ b/hw/core/numa.c
> @@ -168,6 +168,13 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node,
> numa_info[nodenr].present = true;
> max_numa_nodeid = MAX(max_numa_nodeid, nodenr + 1);
> ms->numa_state->num_nodes++;
> + if (ms->smp.max_cpus < ms->numa_state->num_nodes) {
> + error_setg(errp,
> + "Number of NUMA nodes:(%d)"
> + " is larger than number of CPUs:(%d)",
> + ms->numa_state->num_nodes, ms->smp.max_cpus);
> + return;
> + }
> }
>
> static
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-09 6:44 [PATCH] Fix QEMU crash caused when NUMA nodes exceed available CPUs Yin Wang
2023-05-09 12:12 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).