From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Aarushi Mehta" <mehta.aaru20@gmail.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Peter Lieven" <pl@kamp.de>, "Stefan Weil" <sw@weilnetz.de>,
"Xie Yongji" <xieyongji@bytedance.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Peter Xu" <peterx@redhat.com>, "Hanna Reitz" <hreitz@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Coiby Xu" <Coiby.Xu@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Julia Suvorova" <jusual@redhat.com>,
xen-devel@lists.xenproject.org, eesposit@redhat.com,
"Juan Quintela" <quintela@redhat.com>,
"Richard W.M. Jones" <rjones@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH v5 00/21] block: remove aio_disable_external() API
Date: Tue, 9 May 2023 13:51:38 -0400 [thread overview]
Message-ID: <20230509175138.GC1018047@fedora> (raw)
In-Reply-To: <ZFQnSjGiEWuSFWTh@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
On Thu, May 04, 2023 at 11:44:42PM +0200, Kevin Wolf wrote:
> Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben:
> > v5:
> > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin]
> > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event
> > before unrealizing the SCSIDevice [Kevin]
> > - Keep vhost-user-blk export .detach() callback so ctx is set to NULL [Kevin]
> > - Narrow BdrvChildClass and BlockDriver drained_{begin/end/poll} callbacks from
> > IO_OR_GS_CODE() to GLOBAL_STATE_CODE() [Kevin]
> > - Include Kevin's "block: Fix use after free in blockdev_mark_auto_del()" to
> > fix a latent bug that was exposed by this series
>
> I only just finished reviewing v4 when you had already sent v5, but it
> hadn't arrived yet. I had a few more comments on what are now patches
> 17, 18, 19 and 21 in v5. I think they all still apply.
I'm not sure which comments from v4 still apply. In my email client all
your replies were already read when I sent v5.
Maybe you can share the Message-Id of something I still need to address?
Thanks,
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-09 17:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 19:53 [PATCH v5 00/21] block: remove aio_disable_external() API Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 01/21] block: Fix use after free in blockdev_mark_auto_del() Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 02/21] block-backend: split blk_do_set_aio_context() Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 03/21] hw/qdev: introduce qdev_is_realized() helper Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 04/21] virtio-scsi: avoid race between unplug and transport event Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 05/21] virtio-scsi: stop using aio_disable_external() during unplug Stefan Hajnoczi
2023-05-09 18:55 ` Kevin Wolf
2023-05-09 20:43 ` Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 06/21] util/vhost-user-server: rename refcount to in_flight counter Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 07/21] block/export: wait for vhost-user-blk requests when draining Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 08/21] block/export: stop using is_external in vhost-user-blk server Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 10/21] block: add blk_in_drain() API Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 11/21] block: drain from main loop thread in bdrv_co_yield_to_drain() Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin() Stefan Hajnoczi
2023-05-16 14:24 ` Anthony PERARD via
2023-05-16 14:45 ` Anthony PERARD via
2023-05-04 19:53 ` [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds Stefan Hajnoczi
2023-05-16 14:25 ` Anthony PERARD via
2023-05-04 19:53 ` [PATCH v5 14/21] block/export: rewrite vduse-blk drain code Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 15/21] block/export: don't require AioContext lock around blk_exp_ref/unref() Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 16/21] block/fuse: do not set is_external=true on FUSE fd Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 17/21] virtio: make it possible to detach host notifier from any thread Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 18/21] virtio-blk: implement BlockDevOps->drained_begin() Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 19/21] virtio-scsi: " Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 20/21] virtio: do not set is_external=true on host notifiers Stefan Hajnoczi
2023-05-04 19:53 ` [PATCH v5 21/21] aio: remove aio_disable_external() API Stefan Hajnoczi
2023-05-04 21:44 ` [PATCH v5 00/21] block: " Kevin Wolf
2023-05-09 17:51 ` Stefan Hajnoczi [this message]
2023-05-09 18:35 ` Kevin Wolf
2023-05-09 19:07 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509175138.GC1018047@fedora \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=berrange@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=eesposit@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jusual@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mehta.aaru20@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
--cc=ronniesahlberg@gmail.com \
--cc=sgarzare@redhat.com \
--cc=sstabellini@kernel.org \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).