From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: gaosong@loongson.cn, yangxiaojuan@loongson.cn
Subject: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list
Date: Wed, 10 May 2023 07:24:05 +0100 [thread overview]
Message-ID: <20230510062405.127260-1-richard.henderson@linaro.org> (raw)
This list requires a NULL terminator.
Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
This failure can be seen
https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579
5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test ERROR 1.38s killed by signal 6 SIGABRT
44/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/test-hmp ERROR 0.95s killed by signal 6 SIGABRT
356/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/machine-none-test ERROR 0.51s killed by signal 6 SIGABRT
It does not always fail, depending on the layout of the executable,
which is why it was not caught right away. I plan on applying this
directly to master before processing more pull requests.
r~
---
target/loongarch/machine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/loongarch/machine.c b/target/loongarch/machine.c
index 7adc1bdff9..d8ac99c9a4 100644
--- a/target/loongarch/machine.c
+++ b/target/loongarch/machine.c
@@ -163,5 +163,6 @@ const VMStateDescription vmstate_loongarch_cpu = {
.subsections = (const VMStateDescription*[]) {
&vmstate_fpu,
&vmstate_lsx,
+ NULL
}
};
--
2.34.1
next reply other threads:[~2023-05-10 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 6:24 Richard Henderson [this message]
2023-05-10 9:31 ` [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list Song Gao
2023-05-10 15:09 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510062405.127260-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).