From: Olaf Hering <olaf@aepfle.de>
To: Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org,
qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs
Date: Wed, 10 May 2023 09:47:19 +0200 [thread overview]
Message-ID: <20230510094719.26fb79e5.olaf@aepfle.de> (raw)
In-Reply-To: <20230509225818.GA16290@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Wed, 10 May 2023 00:58:27 +0200 Olaf Hering <olaf@aepfle.de>:
> In my debugging (with v8.0.0) it turned out the three pci_set_word
> causes the domU to hang. In fact, it is just the last one:
>
> pci_set_byte(pci_conf + 0x20, 0x01); /* BMIBA: 20-23h */
>
> It changes the value from 0xc121 to 0x1.
If I disable just "pci_set_word(pci_conf + PCI_COMMAND, 0x0000);" it works as well.
It changes the value from 0x5 to 0.
In general I feel it is wrong to fiddle with PCI from the host side.
This is most likely not the intention of the Xen unplug protocol.
I'm sure the guest does not expect such changes under the hood.
It happens to work by luck with pvops kernels because their PCI discovery
is done after the unplug.
So, what do we do here to get this off the table?
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-05-10 7:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 7:00 [PATCH v2] piix: fix regression during unplug in Xen HVM domUs Olaf Hering
2021-03-22 22:09 ` John Snow
2021-03-25 11:12 ` Olaf Hering
2021-03-25 16:49 ` Paolo Bonzini
2023-05-09 22:58 ` Olaf Hering
2023-05-10 7:47 ` Olaf Hering [this message]
2023-05-12 21:12 ` Stefano Stabellini
2023-05-16 17:38 ` John Snow
2023-05-16 20:00 ` Olaf Hering
2023-06-26 21:19 ` Olaf Hering
2023-06-27 7:11 ` Paolo Bonzini
2023-06-27 10:12 ` Bernhard Beschow
2023-06-27 11:40 ` Olaf Hering
2023-06-27 12:07 ` Olaf Hering
2023-06-28 9:27 ` Bernhard Beschow
2023-06-30 7:29 ` Olaf Hering
2023-06-30 8:05 ` Bernhard Beschow
2023-06-30 11:32 ` Olaf Hering
2023-06-30 22:15 ` Bernhard Beschow
2023-06-30 8:48 ` Paolo Bonzini
2023-07-01 9:53 ` Bernhard Beschow
2023-07-01 11:58 ` Mark Cave-Ayland
2023-07-02 22:25 ` Bernhard Beschow
2023-06-27 11:32 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510094719.26fb79e5.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).