qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, "Fabiano Rosas" <farosas@suse.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	qemu-arm@nongnu.org (open list:ARM TCG CPUs)
Subject: [PULL 8/8] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine
Date: Wed, 10 May 2023 16:06:58 +0100	[thread overview]
Message-ID: <20230510150658.1399087-9-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230510150658.1399087-1-alex.bennee@linaro.org>

From: Fabiano Rosas <farosas@suse.de>

This machine hardcodes initialization of the USB device, so select the
corresponding Kconfig. It is not enough to have it as "default y if
XLNX_VERSAL" at usb/Kconfig because building --without-default-devices
disables the default selection resulting in:

$ ./qemu-system-aarch64 -M xlnx-zcu102
qemu-system-aarch64: missing object type 'usb_dwc3'
Aborted (core dumped)

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230208192654.8854-8-farosas@suse.de>
Message-Id: <20230503091244.1450613-8-alex.bennee@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 2d7c457955..0f42c556d7 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -436,6 +436,7 @@ config XLNX_VERSAL
     select OR_IRQ
     select XLNX_BBRAM
     select XLNX_EFUSE_VERSAL
+    select XLNX_USB_SUBSYS
 
 config NPCM7XX
     bool
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index ce4f433976..0ec6def4b8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -136,5 +136,4 @@ config USB_DWC3
 
 config XLNX_USB_SUBSYS
     bool
-    default y if XLNX_VERSAL
     select USB_DWC3
-- 
2.39.2



  parent reply	other threads:[~2023-05-10 15:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 15:06 [PULL 0/8] testing and misc (docker, docs, ci scripts, gitlab, avocado, Kconfig) Alex Bennée
2023-05-10 15:06 ` [PULL 1/8] tests/docker: bump the xtensa base to debian:11-slim Alex Bennée
2023-05-10 15:06 ` [PULL 2/8] docs: document breakpoint and watchpoint support Alex Bennée
2023-05-10 15:06 ` [PULL 3/8] scripts/ci: add gitlab-runner to kvm group Alex Bennée
2023-05-10 15:06 ` [PULL 4/8] scripts/ci: clean-up the 20.04/22.04 confusion in ansible Alex Bennée
2023-05-10 15:06 ` [PULL 5/8] gitlab: add ubuntu-22.04-aarch64-without-defaults Alex Bennée
2023-05-10 15:06 ` [PULL 6/8] gitlab: enable minimal device profile for aarch64 --disable-tcg Alex Bennée
2023-05-10 15:06 ` [PULL 7/8] tests/avocado: use http for mipsdistros.mips.com Alex Bennée
2023-05-10 15:06 ` Alex Bennée [this message]
2023-05-10 17:14 ` [PULL 0/8] testing and misc (docker, docs, ci scripts, gitlab, avocado, Kconfig) Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230510150658.1399087-9-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=farosas@suse.de \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).