From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 23/24] configure: remove unnecessary check
Date: Thu, 11 May 2023 11:50:20 +0200 [thread overview]
Message-ID: <20230511095021.1397802-24-pbonzini@redhat.com> (raw)
In-Reply-To: <20230511095021.1397802-1-pbonzini@redhat.com>
All calls to probe_target_compiler are conditioned on
some "have_target" invocation, or inside a loop on target_list.
Therefore there is no issue with building unnecessary
firmware images and tests.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 7 -------
1 file changed, 7 deletions(-)
diff --git a/configure b/configure
index 074c98e7641d..fd5d6788cbe8 100755
--- a/configure
+++ b/configure
@@ -1323,13 +1323,6 @@ probe_target_compiler() {
container_cross_ranlib=
container_cross_strip=
- # We shall skip configuring the target compiler if the user didn't
- # bother enabling an appropriate guest. This avoids building
- # extraneous firmware images and tests.
- if test "${target_list#*$1}" = "$1"; then
- return 1
- fi
-
target_arch=${1%%-*}
case $target_arch in
aarch64) container_hosts="x86_64 aarch64" ;;
--
2.40.1
next prev parent reply other threads:[~2023-05-11 9:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 9:49 [PATCH 00/24] Meson changes for QEMU 8.1 Paolo Bonzini
2023-05-11 9:49 ` [PATCH 01/24] meson: regenerate meson-buildoptions.sh Paolo Bonzini
2023-05-11 9:49 ` [PATCH 02/24] meson: require 0.63.0 Paolo Bonzini
2023-05-11 9:50 ` [PATCH 03/24] meson: use prefer_static option Paolo Bonzini
2023-05-11 9:50 ` [PATCH 04/24] meson: remove static_kwargs Paolo Bonzini
2023-05-11 9:50 ` [PATCH 05/24] meson: add more version numbers to the summary Paolo Bonzini
2023-05-11 9:50 ` [PATCH 06/24] meson: drop unnecessary declare_dependency() Paolo Bonzini
2023-05-11 9:50 ` [PATCH 07/24] build: move glib detection and workarounds to meson Paolo Bonzini
2023-05-11 9:50 ` [PATCH 08/24] configure: remove pkg-config functions Paolo Bonzini
2023-05-11 9:50 ` [PATCH 09/24] configure, meson: move --enable-modules to Meson Paolo Bonzini
2023-05-11 9:50 ` [PATCH 10/24] meson: prepare move of QEMU_CFLAGS to meson Paolo Bonzini
2023-05-11 9:50 ` [PATCH 11/24] build: move sanitizer tests " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 12/24] build: move SafeStack " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 13/24] build: move coroutine backend selection " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 14/24] build: move stack protector flag " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 15/24] build: move warning " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 16/24] build: move remaining compiler flag tests " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 17/24] build: move compiler version check " Paolo Bonzini
2023-05-11 9:50 ` [PATCH 18/24] build: move --disable-debug-info " Paolo Bonzini
2023-07-26 6:45 ` Michael Tokarev
2023-05-11 9:50 ` [PATCH 19/24] configure: remove compiler sanity check Paolo Bonzini
2024-01-18 19:23 ` Thomas Huth
2023-05-11 9:50 ` [PATCH 20/24] configure: do not rerun the tests with -Werror Paolo Bonzini
2023-05-11 9:50 ` [PATCH 21/24] configure: remove unnecessary mkdir Paolo Bonzini
2023-05-11 9:50 ` [PATCH 22/24] configure: reorder option parsing code Paolo Bonzini
2023-05-11 9:50 ` Paolo Bonzini [this message]
2023-05-11 9:50 ` [PATCH 24/24] docs/devel: update build system docs Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511095021.1397802-24-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).