qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "David Hildenbrand" <david@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Peter Xu" <peterx@redhat.com>,
	"Andrei Gudkov" <gudkov.andrei@huawei.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Zhenzhong Duan" <zhenzhong.duan@intel.com>,
	"Hyman Huang" <huangy81@chinatelecom.cn>
Subject: [PATCH v2 3/5] migration: Teach dirtyrate about qemu_target_page_size()
Date: Thu, 11 May 2023 16:12:06 +0200	[thread overview]
Message-ID: <20230511141208.17779-4-quintela@redhat.com> (raw)
In-Reply-To: <20230511141208.17779-1-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/dirtyrate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 38ea95af59..6706e3fe66 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -314,10 +314,10 @@ static void update_dirtyrate(uint64_t msec)
 static uint32_t get_ramblock_vfn_hash(struct RamblockDirtyInfo *info,
                                       uint64_t vfn)
 {
+    int page_size = qemu_target_page_size();
     uint32_t crc;
 
-    crc = crc32(0, (info->ramblock_addr +
-                vfn * TARGET_PAGE_SIZE), TARGET_PAGE_SIZE);
+    crc = crc32(0, info->ramblock_addr + vfn * page_size, page_size);
 
     trace_get_ramblock_vfn_hash(info->idstr, vfn, crc);
     return crc;
-- 
2.40.1



  parent reply	other threads:[~2023-05-11 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 14:12 [PATCH v2 0/5] migration: Make dirtyrate.c target independent Juan Quintela
2023-05-11 14:12 ` [PATCH v2 1/5] softmmu: Create qemu_target_pages_to_MiB() Juan Quintela
2023-05-11 14:12 ` [PATCH v2 2/5] Use new created qemu_target_pages_to_MiB() Juan Quintela
2023-05-11 14:12 ` Juan Quintela [this message]
2023-05-11 18:56   ` [PATCH v2 3/5] migration: Teach dirtyrate about qemu_target_page_size() Philippe Mathieu-Daudé
2023-05-11 19:16     ` Juan Quintela
2023-05-11 14:12 ` [PATCH v2 4/5] migration: Teach dirtyrate about qemu_target_page_bits() Juan Quintela
2023-05-11 14:12 ` [PATCH v2 5/5] migration: Make dirtyrate.c target independent Juan Quintela
2023-05-11 18:58   ` Philippe Mathieu-Daudé
2023-05-11 17:16 ` [PATCH v2 0/5] " Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230511141208.17779-4-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=david@redhat.com \
    --cc=gudkov.andrei@huawei.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=leobras@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).