qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Melnychenko <andrew@daynix.com>
To: jasowang@redhat.com, mst@redhat.com, armbru@redhat.com,
	eblake@redhat.com, qemu-devel@nongnu.org, berrange@redhat.com
Cc: yuri.benditovich@daynix.com, yan@daynix.com
Subject: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.
Date: Fri, 12 May 2023 15:29:01 +0300	[thread overview]
Message-ID: <20230512122902.34345-6-andrew@daynix.com> (raw)
In-Reply-To: <20230512122902.34345-1-andrew@daynix.com>

Added command "request-ebpf". This command returns
eBPF program encoded base64. The program taken from the
skeleton and essentially is an ELF object that can be
loaded in the future with libbpf.

Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
---
 monitor/qmp-cmds.c | 16 ++++++++++++++++
 qapi/misc.json     | 38 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index b0f948d3376..259bc87ccb1 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -32,6 +32,7 @@
 #include "hw/mem/memory-device.h"
 #include "hw/intc/intc.h"
 #include "hw/rdma/rdma.h"
+#include "ebpf/ebpf.h"
 
 NameInfo *qmp_query_name(Error **errp)
 {
@@ -209,3 +210,18 @@ static void __attribute__((__constructor__)) monitor_init_qmp_commands(void)
                          qmp_marshal_qmp_capabilities,
                          QCO_ALLOW_PRECONFIG, 0);
 }
+
+EbpfObject *qmp_request_ebpf(EbpfProgramID id, Error **errp)
+{
+    EbpfObject *ret = NULL;
+    size_t size = 0;
+    const void *data = ebpf_find_binary_by_id(id, &size, errp);
+    if (!data) {
+        return NULL;
+    }
+
+    ret = g_new0(EbpfObject, 1);
+    ret->object = g_base64_encode(data, size);
+
+    return ret;
+}
diff --git a/qapi/misc.json b/qapi/misc.json
index 6ddd16ea283..e96dac8482b 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -618,3 +618,41 @@
 { 'event': 'VFU_CLIENT_HANGUP',
   'data': { 'vfu-id': 'str', 'vfu-qom-path': 'str',
             'dev-id': 'str', 'dev-qom-path': 'str' } }
+
+##
+# @EbpfObject:
+#
+# Structure that holds eBPF ELF object encoded in base64.
+#
+# Since: 8.1
+#
+##
+{ 'struct': 'EbpfObject',
+  'data': {'object': 'str'} }
+
+##
+# @EbpfProgramID:
+#
+# An enumeration of the eBPF programs. Currently, only RSS is presented.
+#
+# Since: 8.1
+##
+{ 'enum': 'EbpfProgramID',
+  'data': [ { 'name': 'rss', 'if': 'CONFIG_EBPF' } ] }
+
+##
+# @request-ebpf:
+#
+# Function returns eBPF object that can be loaded with libbpf.
+# Management applications (g.e. libvirt) may load it and pass file
+# descriptors to QEMU. Which allows running QEMU without BPF capabilities.
+#
+# Returns: RSS eBPF object encoded in base64.
+#
+# Since: 8.1
+#
+##
+{ 'command': 'request-ebpf',
+  'data': { 'id': 'EbpfProgramID' },
+  'returns': 'EbpfObject' }
+
-- 
2.39.1



  parent reply	other threads:[~2023-05-12 12:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 12:28 [PATCH v2 0/6] eBPF RSS through QMP support Andrew Melnychenko
2023-05-12 12:28 ` [PATCH v2 1/6] ebpf: Added eBPF map update through mmap Andrew Melnychenko
2023-05-15  9:34   ` Daniel P. Berrangé
2023-05-12 12:28 ` [PATCH v2 2/6] ebpf: Added eBPF initialization by fds Andrew Melnychenko
2023-05-15  9:35   ` Daniel P. Berrangé
2023-05-12 12:28 ` [PATCH v2 3/6] virtio-net: Added property to load eBPF RSS with fds Andrew Melnychenko
2023-05-15  9:38   ` Daniel P. Berrangé
2023-05-15 10:53     ` Andrew Melnichenko
2023-05-16 21:21     ` Eric Blake
2023-05-12 12:29 ` [PATCH v2 4/6] ebpf: Added declaration/initialization routines Andrew Melnychenko
2023-05-15  9:44   ` Daniel P. Berrangé
2023-05-12 12:29 ` Andrew Melnychenko [this message]
2023-05-15  9:50   ` [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob Daniel P. Berrangé
2023-05-16  8:47     ` Markus Armbruster
2023-05-16  8:54       ` Daniel P. Berrangé
2023-05-16 10:23         ` Markus Armbruster
2023-05-16 10:29           ` Daniel P. Berrangé
2023-05-16 14:04             ` Markus Armbruster
2023-05-16 14:35               ` Daniel P. Berrangé
2023-05-16 15:06                 ` Markus Armbruster
2023-05-16 15:18                   ` Daniel P. Berrangé
2023-05-22 10:50                     ` Markus Armbruster
2023-05-12 12:29 ` [PATCH v2 6/6] ebpf: Updated eBPF program and skeleton Andrew Melnychenko
2023-05-15  9:53   ` Daniel P. Berrangé
2023-05-16 21:29   ` Eric Blake
2023-05-12 12:31 ` [PATCH v2 0/6] eBPF RSS through QMP support Andrew Melnichenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230512122902.34345-6-andrew@daynix.com \
    --to=andrew@daynix.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).