qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Coiby Xu" <Coiby.Xu@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	xen-devel@lists.xenproject.org, "Kevin Wolf" <kwolf@redhat.com>,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Julia Suvorova" <jusual@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	eesposit@redhat.com, "Fam Zheng" <fam@euphon.net>,
	"Aarushi Mehta" <mehta.aaru20@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Xie Yongji" <xieyongji@bytedance.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	qemu-block@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
	"Paul Durrant" <paul@xen.org>, "Stefan Weil" <sw@weilnetz.de>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Lieven" <pl@kamp.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"David Woodhouse" <dwmw@amazon.co.uk>
Subject: [PATCH v6 08/20] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore
Date: Tue, 16 May 2023 15:02:26 -0400	[thread overview]
Message-ID: <20230516190238.8401-9-stefanha@redhat.com> (raw)
In-Reply-To: <20230516190238.8401-1-stefanha@redhat.com>

There is no need to suspend activity between aio_disable_external() and
aio_enable_external(), which is mainly used for the block layer's drain
operation.

This is part of ongoing work to remove the aio_disable_external() API.

Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/i386/kvm/xen_xenstore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c
index 900679af8a..6e81bc8791 100644
--- a/hw/i386/kvm/xen_xenstore.c
+++ b/hw/i386/kvm/xen_xenstore.c
@@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp)
         error_setg(errp, "Xenstore evtchn port init failed");
         return;
     }
-    aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true,
+    aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false,
                        xen_xenstore_event, NULL, NULL, NULL, s);
 
     s->impl = xs_impl_create(xen_domid);
-- 
2.40.1



  parent reply	other threads:[~2023-05-16 19:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 19:02 [PATCH v6 00/20] block: remove aio_disable_external() API Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 01/20] block-backend: split blk_do_set_aio_context() Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 02/20] hw/qdev: introduce qdev_is_realized() helper Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 03/20] virtio-scsi: avoid race between unplug and transport event Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 04/20] virtio-scsi: stop using aio_disable_external() during unplug Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 05/20] util/vhost-user-server: rename refcount to in_flight counter Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 06/20] block/export: wait for vhost-user-blk requests when draining Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 07/20] block/export: stop using is_external in vhost-user-blk server Stefan Hajnoczi
2023-05-16 19:02 ` Stefan Hajnoczi [this message]
2023-05-16 19:02 ` [PATCH v6 09/20] block: add blk_in_drain() API Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 10/20] block: drain from main loop thread in bdrv_co_yield_to_drain() Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 11/20] xen-block: implement BlockDevOps->drained_begin() Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 12/20] hw/xen: do not set is_external=true on evtchn fds Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 13/20] block/export: rewrite vduse-blk drain code Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 14/20] block/export: don't require AioContext lock around blk_exp_ref/unref() Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 15/20] block/fuse: do not set is_external=true on FUSE fd Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 16/20] virtio: make it possible to detach host notifier from any thread Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 17/20] virtio-blk: implement BlockDevOps->drained_begin() Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 18/20] virtio-scsi: " Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 19/20] virtio: do not set is_external=true on host notifiers Stefan Hajnoczi
2023-05-16 19:02 ` [PATCH v6 20/20] aio: remove aio_disable_external() API Stefan Hajnoczi
2023-05-30 16:24 ` [PATCH v6 00/20] block: " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516190238.8401-9-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=Coiby.Xu@gmail.com \
    --cc=anthony.perard@citrix.com \
    --cc=berrange@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=dwmw@amazon.co.uk \
    --cc=eduardo@habkost.net \
    --cc=eesposit@redhat.com \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=jusual@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=leobras@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mehta.aaru20@gmail.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=rjones@redhat.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=sgarzare@redhat.com \
    --cc=sstabellini@kernel.org \
    --cc=sw@weilnetz.de \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).