From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: michael.roth@amd.com, jsnow@redhat.com,
richard.henderson@linaro.org, imammedo@redhat.com
Subject: [PATCH] qapi/parser: Drop two bad type hints for now
Date: Wed, 17 May 2023 08:16:00 +0200 [thread overview]
Message-ID: <20230517061600.1782455-1-armbru@redhat.com> (raw)
Two type hints fail centos-stream-8-x86_64 CI. They are actually
broken. Changing them to Optional[re.Match[str]] fixes them locally
for me, but then CI fails differently. Drop them for now.
Fixes: 3e32dca3f0d1 (qapi: Rewrite parsing of doc comment section symbols and tags)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/parser.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 4923a59d60..1ff334e6a8 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -563,11 +563,11 @@ def end_comment(self) -> None:
self._switch_section(QAPIDoc.NullSection(self._parser))
@staticmethod
- def _match_at_name_colon(string: str) -> re.Match:
+ def _match_at_name_colon(string: str):
return re.match(r'@([^:]*): *', string)
@staticmethod
- def _match_section_tag(string: str) -> re.Match:
+ def _match_section_tag(string: str):
return re.match(r'(Returns|Since|Notes?|Examples?|TODO): *', string)
def _append_body_line(self, line: str) -> None:
--
2.39.2
next reply other threads:[~2023-05-17 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 6:16 Markus Armbruster [this message]
2023-05-17 12:46 ` [PATCH] qapi/parser: Drop two bad type hints for now Richard Henderson
2023-05-17 13:29 ` Igor Mammedov
-- strict thread matches above, loose matches on Subject: below --
2023-05-17 15:25 [PULL 0/5] QAPI patches patches for 2023-05-17 Markus Armbruster
2023-05-17 15:25 ` [PATCH] qapi/parser: Drop two bad type hints for now Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517061600.1782455-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).