From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location
Date: Thu, 18 May 2023 06:40:12 -0400 [thread overview]
Message-ID: <20230518063559-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <C2CC04A8-F0F1-4360-ABF0-1F8DF7768AB1@redhat.com>
On Thu, May 18, 2023 at 11:31:47AM +0530, Ani Sinha wrote:
>
>
> > On 17-May-2023, at 9:50 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
> >
> > ./tests/bios-tables-test --iasl-path ${CONFIG_IASL}
> >
> > and then you have the best of both worlds. You can run manually with a
> > different path and you don't need to pollute config-host.h
>
> It could also be an environment variable set by meson. Then bios-tables-test can do a genenv() just like it does for verbosity etc. The environment can also be used by other tools that might need iasl in the future. We do not need to introduce new command line option.
The annoying thing with both these approaches is they work
less well than current code since iasl won't be invoked
at all if you do not remember the magic variable to set
or flag to pass. ATM it is self-contained.
Can we split this variable out to config-test.h maybe?
Then you can reconfigure with a different iasl and QEMU
will not be rebuilt, just the tests.
--
MST
next prev parent reply other threads:[~2023-05-18 10:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:07 [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location Ani Sinha
2023-05-17 14:17 ` Michael S. Tsirkin
2023-05-17 14:27 ` Ani Sinha
2023-05-17 14:36 ` Michael S. Tsirkin
2023-05-17 14:49 ` Ani Sinha
2023-05-17 15:16 ` Alex Bennée
2023-05-17 15:25 ` Michael S. Tsirkin
2023-05-17 15:58 ` Alex Bennée
2023-05-17 16:07 ` Michael S. Tsirkin
2023-05-17 16:20 ` Alex Bennée
2023-05-18 6:01 ` Ani Sinha
2023-05-18 10:40 ` Michael S. Tsirkin [this message]
2023-05-18 11:01 ` Ani Sinha
2023-05-19 17:13 ` Paolo Bonzini
2023-05-20 7:25 ` Ani Sinha
2023-05-20 9:36 ` Paolo Bonzini
2023-05-20 15:13 ` Ani Sinha
2023-05-22 10:21 ` Paolo Bonzini
2023-05-18 11:19 ` Ani Sinha
2023-05-18 6:11 ` Ani Sinha
2023-05-17 15:48 ` Ani Sinha
2023-05-17 16:07 ` Alex Bennée
2023-05-17 16:43 ` Bernhard Beschow
2023-05-18 5:55 ` Ani Sinha
2023-05-18 10:27 ` Michael S. Tsirkin
2023-05-21 8:54 ` Michael S. Tsirkin
2023-05-21 14:51 ` Ani Sinha
2023-05-22 10:34 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518063559-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).