qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lei Wang <lei4.wang@intel.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com,
	wei.w.wang@intel.com, lei4.wang@intel.com
Subject: [PATCH] multifd: Set a higher "backlog" default value for listen()
Date: Thu, 18 May 2023 04:52:28 -0400	[thread overview]
Message-ID: <20230518085228.172816-1-lei4.wang@intel.com> (raw)

When destination VM is launched, the "backlog" parameter for listen() is set
to 1 as default in socket_start_incoming_migration_internal(), which will
lead to socket connection error (the queue of pending connections is full)
when "multifd" and "multifd-channels" are set later on and a high number of
channels are used. Set it to a hard-coded higher default value 512 to fix
this issue.

Reported-by: Wei Wang <wei.w.wang@intel.com>
Signed-off-by: Lei Wang <lei4.wang@intel.com>
---
 migration/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/socket.c b/migration/socket.c
index 1b6f5baefb..b43a66ef7e 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -179,7 +179,7 @@ socket_start_incoming_migration_internal(SocketAddress *saddr,
     QIONetListener *listener = qio_net_listener_new();
     MigrationIncomingState *mis = migration_incoming_get_current();
     size_t i;
-    int num = 1;
+    int num = 512;
 
     qio_net_listener_set_name(listener, "migration-socket-listener");
 
-- 
2.39.1



             reply	other threads:[~2023-05-18  8:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18  8:52 Lei Wang [this message]
2023-05-18  9:13 ` [PATCH] multifd: Set a higher "backlog" default value for listen() Wang, Wei W
2023-05-18 11:44   ` Juan Quintela
2023-05-18 12:29   ` Daniel P. Berrangé
2023-05-18 12:42     ` Juan Quintela
2023-05-18 15:17       ` Wang, Wei W
2023-05-18 15:28         ` Juan Quintela
2023-05-18  9:16 ` Juan Quintela
2023-05-19  1:30   ` Wang, Lei
2023-05-19  2:44     ` Wang, Wei W
2023-05-19  2:51       ` Wang, Lei
2023-05-19  3:33         ` Wang, Wei W
2023-05-19 11:32           ` Juan Quintela
2023-05-19 11:22       ` Juan Quintela
2023-05-19 15:17         ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230518085228.172816-1-lei4.wang@intel.com \
    --to=lei4.wang@intel.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).