From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PULL 4/7] configure: fix backwards-compatibility for meson sphinx_build option
Date: Sat, 20 May 2023 21:06:29 +0200 [thread overview]
Message-ID: <20230520190632.7491-5-pbonzini@redhat.com> (raw)
In-Reply-To: <20230520190632.7491-1-pbonzini@redhat.com>
Reintroduce the cmd_line.txt mangling to remove the sphinx_build option
when rerunning meson. The mechanism was removed in commit 75cc28648574
("configure: remove backwards-compatibility code", 2023-01-11) because
the fixups were obsolete at the time; however, the Meson deprecation
mechanism doesn't quite work when options are finally removed, so we
need to bring it back.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/configure b/configure
index bcab685cfd97..f7cd376e525f 100755
--- a/configure
+++ b/configure
@@ -1987,6 +1987,14 @@ if test "$skip_meson" = no; then
if test "$?" -ne 0 ; then
error_exit "meson setup failed"
fi
+else
+ if test -f meson-private/cmd_line.txt; then
+ # Adjust old command line options that were removed
+ # sed -i is not portable
+ perl -i -ne '
+ /^sphinx_build/ && next;
+ print;' meson-private/cmd_line.txt
+ fi
fi
# Save the configure command line for later reuse.
--
2.40.1
next prev parent reply other threads:[~2023-05-20 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 19:06 [PULL 0/7] Python fixes and related patches Paolo Bonzini
2023-05-20 19:06 ` [PULL 1/7] remove remaining traces of meson submodule Paolo Bonzini
2023-05-20 19:06 ` [PULL 2/7] mkvenv: replace distlib.database with importlib.metadata/pkg_resources Paolo Bonzini
2023-05-20 19:06 ` [PULL 3/7] build: rebuild build.ninja using "meson setup --reconfigure" Paolo Bonzini
2023-05-20 19:06 ` Paolo Bonzini [this message]
2023-05-20 19:06 ` [PULL 5/7] mkvenv: pass first missing package to diagnose() Paolo Bonzini
2023-05-20 19:06 ` [PULL 6/7] gitlab: custom-runners: preserve more artifacts for debugging Paolo Bonzini
2023-05-20 19:06 ` [PULL 7/7] scripts: make sure scripts are invoked via $(PYTHON) Paolo Bonzini
2023-05-22 14:02 ` [PULL 0/7] Python fixes and related patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520190632.7491-5-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).