From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 7/7] scripts: make sure scripts are invoked via $(PYTHON)
Date: Sat, 20 May 2023 21:06:32 +0200 [thread overview]
Message-ID: <20230520190632.7491-8-pbonzini@redhat.com> (raw)
In-Reply-To: <20230520190632.7491-1-pbonzini@redhat.com>
Some scripts are invoked via the first "python3" binary in the PATH,
because they are executable and their shebang line is "#! /usr/bin/env
python3". To enforce usage of $(PYTHON), make them nonexecutable.
Scripts invoked via meson need nothing else, and meson-buildoptions.py
is already using $(PYTHON). For probe-gdb-support.py however the
invocation in the configure script has to be adjusted.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 2 +-
scripts/meson-buildoptions.py | 0
scripts/modinfo-collect.py | 0
scripts/modinfo-generate.py | 0
scripts/probe-gdb-support.py | 0
5 files changed, 1 insertion(+), 1 deletion(-)
mode change 100755 => 100644 scripts/meson-buildoptions.py
mode change 100755 => 100644 scripts/modinfo-collect.py
mode change 100755 => 100644 scripts/modinfo-generate.py
mode change 100755 => 100644 scripts/probe-gdb-support.py
diff --git a/configure b/configure
index f7cd376e525f..1bdc7fd69b7b 100755
--- a/configure
+++ b/configure
@@ -1767,7 +1767,7 @@ if test -n "$gdb_bin"; then
gdb_version=$($gdb_bin --version | head -n 1)
if version_ge ${gdb_version##* } 9.1; then
echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
- gdb_arches=$("$source_path/scripts/probe-gdb-support.py" $gdb_bin)
+ gdb_arches=$($python "$source_path/scripts/probe-gdb-support.py" $gdb_bin)
else
gdb_bin=""
fi
diff --git a/scripts/meson-buildoptions.py b/scripts/meson-buildoptions.py
old mode 100755
new mode 100644
diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py
old mode 100755
new mode 100644
diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py
old mode 100755
new mode 100644
diff --git a/scripts/probe-gdb-support.py b/scripts/probe-gdb-support.py
old mode 100755
new mode 100644
--
2.40.1
next prev parent reply other threads:[~2023-05-20 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 19:06 [PULL 0/7] Python fixes and related patches Paolo Bonzini
2023-05-20 19:06 ` [PULL 1/7] remove remaining traces of meson submodule Paolo Bonzini
2023-05-20 19:06 ` [PULL 2/7] mkvenv: replace distlib.database with importlib.metadata/pkg_resources Paolo Bonzini
2023-05-20 19:06 ` [PULL 3/7] build: rebuild build.ninja using "meson setup --reconfigure" Paolo Bonzini
2023-05-20 19:06 ` [PULL 4/7] configure: fix backwards-compatibility for meson sphinx_build option Paolo Bonzini
2023-05-20 19:06 ` [PULL 5/7] mkvenv: pass first missing package to diagnose() Paolo Bonzini
2023-05-20 19:06 ` [PULL 6/7] gitlab: custom-runners: preserve more artifacts for debugging Paolo Bonzini
2023-05-20 19:06 ` Paolo Bonzini [this message]
2023-05-22 14:02 ` [PULL 0/7] Python fixes and related patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520190632.7491-8-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).