From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A5B3C7EE26 for ; Mon, 22 May 2023 12:00:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q14Cc-0003MF-MA; Mon, 22 May 2023 07:59:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q14CU-0003LZ-H8 for qemu-devel@nongnu.org; Mon, 22 May 2023 07:59:45 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q14CR-00012Z-Sr for qemu-devel@nongnu.org; Mon, 22 May 2023 07:59:42 -0400 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QPwtT37fhz67Zjl; Mon, 22 May 2023 19:57:37 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 22 May 2023 12:59:32 +0100 Date: Mon, 22 May 2023 12:59:31 +0100 To: Peter Maydell CC: , Michael Tsirkin , Fan Ni , , , "Ira Weiny" , Michael Roth , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Dave Jiang , Markus Armbruster , "Daniel P . =?ISO-8859-1?Q?Berrang=E9?=" , Eric Blake , Mike Maslenkin , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , "Thomas Huth" Subject: Re: [PATCH v6 1/4] bswap: Add the ability to store to an unaligned 24 bit field Message-ID: <20230522125931.0000309a@Huawei.com> In-Reply-To: References: <20230519141803.29713-1-Jonathan.Cameron@huawei.com> <20230519141803.29713-2-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, 20 May 2023 13:37:42 +0100 Peter Maydell wrote: > On Fri, 19 May 2023 at 15:19, Jonathan Cameron via > wrote: > > > > From: Ira Weiny > > > > CXL has 24 bit unaligned fields which need to be stored to. CXL is > > specified as little endian. > > > > Define st24_le_p() and the supporting functions to store such a field > > from a 32 bit host native value. > > > > The use of b, w, l, q as the size specifier is limiting. So "24" was > > used for the size part of the function name. > > > > Signed-off-by: Ira Weiny > > Signed-off-by: Jonathan Cameron > > --- > > docs/devel/loads-stores.rst | 1 + > > include/qemu/bswap.h | 27 +++++++++++++++++++++++++++ > > 2 files changed, 28 insertions(+) > > > > diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst > > index d2cefc77a2..82a79e91d9 100644 > > --- a/docs/devel/loads-stores.rst > > +++ b/docs/devel/loads-stores.rst > > @@ -36,6 +36,7 @@ store: ``st{size}_{endian}_p(ptr, val)`` > > ``size`` > > - ``b`` : 8 bits > > - ``w`` : 16 bits > > + - ``24`` : 24 bits > > - ``l`` : 32 bits > > - ``q`` : 64 bits > > Can you also update the "Regexes for git grep" section > below to account for the new size value, please? Ok. My regex isn't great, but I think this would require either some separate entries or a switch to git grep -E to allow for the multiple character matching. So I've added - ``\st24\(_[hbl]e\)\?_p\>`` > > thanks > -- PMM