From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Bernhard Beschow" <shentey@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
qemu-ppc@nongnu.org, "Titus Rwantare" <titusr@google.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 0/3] hw: Fix abuse of QOM class internals modified by their instances
Date: Tue, 23 May 2023 08:44:05 +0200 [thread overview]
Message-ID: <20230523064408.57941-1-philmd@linaro.org> (raw)
Bernhard warned for QOM class abuse here [*]:
> A realize method is supposed to modify a single instance only
> while we're modifying the behavior of whole classes here, i.e.
> will affect every instance of these classes. This goes against
> QOM design principles and will therefore be confusing for people
> who are familiar with QOM in particular and OOP in general.
This series fixes the cases I found while auditing.
[*] https://lore.kernel.org/qemu-devel/0DAAC63B-0C0F-44C4-B7EB-ACD6C9A36BF1@gmail.com/
Philippe Mathieu-Daudé (3):
hw/mips/jazz: Fix modifying QOM class internal state from instance
hw/ppc/e500plat: Fix modifying QOM class internal state from instance
hw/i2c/pmbus_device: Fix modifying QOM class internals from instance
hw/i2c/pmbus_device.c | 17 ++++++++++-------
hw/mips/jazz.c | 41 +++++++++++++++++++++++------------------
hw/ppc/e500plat.c | 25 +++++++++++--------------
3 files changed, 44 insertions(+), 39 deletions(-)
--
2.38.1
next reply other threads:[~2023-05-23 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 6:44 Philippe Mathieu-Daudé [this message]
2023-05-23 6:44 ` [PATCH 1/3] hw/mips/jazz: Fix modifying QOM class internal state from instance Philippe Mathieu-Daudé
2023-05-23 18:26 ` Richard Henderson
2023-05-23 6:44 ` [PATCH 2/3] hw/ppc/e500plat: " Philippe Mathieu-Daudé
2023-05-23 9:03 ` Alexander Graf
2023-05-23 18:29 ` Richard Henderson
2023-05-23 6:44 ` [PATCH 3/3] hw/i2c/pmbus_device: Fix modifying QOM class internals " Philippe Mathieu-Daudé
2023-05-23 18:30 ` Richard Henderson
2023-05-23 7:10 ` [PATCH 0/3] hw: Fix abuse of QOM class internals modified by their instances Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523064408.57941-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shentey@gmail.com \
--cc=titusr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).