From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: [PATCH 1/6] tests/decodetree/check.sh: Exit failure for all failures
Date: Tue, 23 May 2023 13:04:42 +0100 [thread overview]
Message-ID: <20230523120447.728365-2-peter.maydell@linaro.org> (raw)
In-Reply-To: <20230523120447.728365-1-peter.maydell@linaro.org>
The check.sh script doesn't set its exit status to 1 for failures in
the succ_* (should-pass) tests, only for the err_* (should-error)
tests. This means that even on a test failure meson will report that
the test suite passed. Set the exit status for all failures.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
In an ideal world we'd tell meson how to run each test, so that
we got per-test pass/fail/log information, I suppose.
---
tests/decode/check.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/decode/check.sh b/tests/decode/check.sh
index 95445a01155..4b5a47fbbf2 100755
--- a/tests/decode/check.sh
+++ b/tests/decode/check.sh
@@ -18,6 +18,7 @@ done
for i in succ_*.decode; do
if ! $PYTHON $DECODETREE $i > /dev/null 2> /dev/null; then
echo FAIL:$i 1>&2
+ E=1
fi
done
--
2.34.1
next prev parent reply other threads:[~2023-05-23 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 12:04 [PATCH 0/6] decodetree: support named fields Peter Maydell
2023-05-23 12:04 ` Peter Maydell [this message]
2023-05-23 17:49 ` [PATCH 1/6] tests/decodetree/check.sh: Exit failure for all failures Richard Henderson
2023-05-23 12:04 ` [PATCH 2/6] docs: Document decodetree named field syntax Peter Maydell
2023-05-23 17:59 ` Richard Henderson
2023-05-23 12:04 ` [PATCH 3/6] scripts/decodetree: Pass lvalue-formatter function to str_extract() Peter Maydell
2023-05-23 18:02 ` Richard Henderson
2023-05-23 12:04 ` [PATCH 4/6] scripts/decodetree: Implement a topological sort Peter Maydell
2023-05-23 18:12 ` Richard Henderson
2023-05-23 12:04 ` [PATCH 5/6] scripts/decodetree: Implement named field support Peter Maydell
2023-05-23 18:17 ` Richard Henderson
2023-05-23 12:04 ` [PATCH 6/6] tests/decode: Add tests for various named-field cases Peter Maydell
2023-05-23 18:20 ` Richard Henderson
2023-05-24 10:26 ` Peter Maydell
2023-05-26 17:07 ` Richard Henderson
2023-05-26 19:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523120447.728365-2-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).