From: Andrey Drobyshev via <qemu-devel@nongnu.org>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
shmuel.eiderman@oracle.com, andrey.drobyshev@virtuozzo.com,
den@virtuozzo.com
Subject: [PATCH 0/2] qemu-img: fix getting stuck in infinite loop on
Date: Tue, 23 May 2023 19:24:56 +0300 [thread overview]
Message-ID: <20230523162458.704266-1-andrey.drobyshev@virtuozzo.com> (raw)
Consider the following in-chain rebase case:
qemu-img create -f qcow2 base.qcow2 $(( 64 * 4 ))k
qemu-img create -f qcow2 -o backing_file=base.qcow2,backing_fmt=qcow2 inc1.qcow2 $(( 64 * 4 ))k
qemu-img create -f qcow2 -o backing_file=inc1.qcow2,backing_fmt=qcow2 inc2.qcow2 $(( 64 * 5 ))k
qemu-img rebase -f qcow2 -b base.qcow2 -F qcow2 inc2.qcow2
And then rebase operation gets stuck forever.
The 1st patch is a fix, the 2nd -- an additional test case to catch this
situation.
Andrey Drobyshev (2):
qemu-img: rebase: stop when reaching EOF of old backing file
qemu-iotests: 024: add rebasing test case for overlay_size >
backing_size
qemu-img.c | 7 ++++++
tests/qemu-iotests/024 | 48 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/024.out | 23 ++++++++++++++++++
3 files changed, 78 insertions(+)
--
2.31.1
next reply other threads:[~2023-05-23 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 16:24 Andrey Drobyshev via [this message]
2023-05-23 16:24 ` [PATCH 1/2] qemu-img: rebase: stop when reaching EOF of old backing file Andrey Drobyshev via
2023-05-24 8:30 ` Denis V. Lunev
2023-05-25 10:37 ` Andrey Drobyshev
2023-05-23 16:24 ` [PATCH 2/2] qemu-iotests: 024: add rebasing test case for overlay_size > backing_size Andrey Drobyshev via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523162458.704266-1-andrey.drobyshev@virtuozzo.com \
--to=qemu-devel@nongnu.org \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).